Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(127)

Issue 6252048: code review 6252048: cmd/gc: fix parallel assignment in range (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by rsc
Modified:
12 years, 9 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

cmd/gc: fix parallel assignment in range for expr1, expr2 = range slice was assigning to expr1 and expr2 in sequence instead of in parallel. Now it assigns in parallel, as it should. This matters for things like for i, x[i] = range slice. Fixes issue 3464.

Patch Set 1 #

Patch Set 2 : diff -r 98488e2e38ee https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 98488e2e38ee https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -3 lines) Patch
M src/cmd/gc/range.c View 1 1 chunk +8 lines, -3 lines 0 comments Download
M src/cmd/gc/subr.c View 1 1 chunk +6 lines, -0 lines 0 comments Download
M test/range.go View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 9 months ago (2012-05-25 03:05:34 UTC) #1
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=2252777854d2 *** cmd/gc: fix parallel assignment in range for expr1, expr2 = ...
12 years, 9 months ago (2012-05-25 03:05:44 UTC) #2
ken3
12 years, 9 months ago (2012-05-25 13:21:54 UTC) #3
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b