Issue 6252043: Provides a method to use original special phrase.

Issue 6252043: Provides a method to use original special phrase. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by hsumita1

Modified:
11 years, 11 months ago

Reviewers:
shawn.p.huang, Peng Huang, penghuang, Peng

Base URL:
git@github.com:pyzy/pyzy.git@master

Visibility:
Public.

More Reviews

Description

Provides a method to use original special phrase. BUG=None TEST=Manual

Patch Set 2 : #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -18 lines)			Patch
M	src/PyZyDatabase.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/PyZyInputContext.h	View		1 chunk	+12 lines, -4 lines	0 comments	Download
M	src/PyZyInputContext.cc	View		1 chunk	+16 lines, -6 lines	0 comments	Download
M	src/PyZySpecialPhraseTable.h	View	1	2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/PyZySpecialPhraseTable.cc	View	1	3 chunks	+24 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

https://codereview.appspot.com/6252043/diff/1/src/PyZyDatabase.h File src/PyZyDatabase.h (right): https://codereview.appspot.com/6252043/diff/1/src/PyZyDatabase.h#newcode83 src/PyZyDatabase.h:83: g_error ("Error: Please call InputContext::init () !"); g_error? pyzy ...

11 years, 11 months ago (2012-05-24 13:10:36 UTC) #2

hsumita1

11 years, 11 months ago (2012-05-25 05:08:52 UTC) #3

Peng

11 years, 11 months ago (2012-05-25 12:04:15 UTC) #4

lgtm
On 2012/05/25 05:08:52, hsumita1 wrote:
> https://codereview.appspot.com/6252043/diff/1/src/PyZyDatabase.h
> File src/PyZyDatabase.h (right):
> 
> https://codereview.appspot.com/6252043/diff/1/src/PyZyDatabase.h#newcode83
> src/PyZyDatabase.h:83: g_error ("Error: Please call InputContext::init () !");
> On 2012/05/24 13:10:36, Peng wrote:
> > g_error? pyzy still depends on glib?
> 
> Yes. We have some codes to handle UCS4 and UTF8, and it requires glib
functions.
> 
> https://codereview.appspot.com/6252043/diff/1/src/PyZySpecialPhraseTable.cc
> File src/PyZySpecialPhraseTable.cc (right):
> 
>
https://codereview.appspot.com/6252043/diff/1/src/PyZySpecialPhraseTable.cc#n...
> src/PyZySpecialPhraseTable.cc:108: m_instance.reset (new SpecialPhraseTable);
> On 2012/05/24 13:10:36, Peng wrote:
> > How about just pass config_dir as a param of SpecialPhraseTable constructor?
> 
> Done.

Expand All Messages | Collapse All Messages