Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(152)

Issue 6250080: Add SkFontDescriptor for serializing fonts. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by DerekS
Modified:
12 years, 1 month ago
Reviewers:
bungeman, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add SkFontDescriptor for serializing fonts. Committed: https://code.google.com/p/skia/source/detail?r=4106

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -106 lines) Patch
M gyp/ports.gyp View 1 1 chunk +1 line, -0 lines 1 comment Download
M include/core/SkFontHost.h View 1 1 chunk +7 lines, -2 lines 0 comments Download
A src/ports/SkFontDescriptor.h View 1 1 chunk +40 lines, -0 lines 0 comments Download
A src/ports/SkFontDescriptor.cpp View 1 1 chunk +73 lines, -0 lines 0 comments Download
M src/ports/SkFontHost_android.cpp View 1 3 chunks +34 lines, -58 lines 1 comment Download
M src/ports/SkFontHost_linux.cpp View 1 5 chunks +53 lines, -46 lines 0 comments Download

Messages

Total messages: 6
DerekS
Here is the initial header that I was thinking of
12 years, 1 month ago (2012-05-31 13:37:05 UTC) #1
reed1
its possible that we will want to make the read/write helpers be a little lower-level ...
12 years, 1 month ago (2012-05-31 13:48:18 UTC) #2
reed1
Lets just be sure to code the read/write methods to be open-ended about the number ...
12 years, 1 month ago (2012-05-31 13:49:22 UTC) #3
DerekS
This patch set includes the completed implementation as well as updating android and linux to ...
12 years, 1 month ago (2012-05-31 18:46:22 UTC) #4
bungeman
Other than the gyp nit, LGTM. http://codereview.appspot.com/6250080/diff/4001/gyp/ports.gyp File gyp/ports.gyp (right): http://codereview.appspot.com/6250080/diff/4001/gyp/ports.gyp#newcode23 gyp/ports.gyp:23: '../src/ports/SkFontDescriptor.cpp', '../src/ports/SkFontDescriptor.h', makes ...
12 years, 1 month ago (2012-05-31 19:07:37 UTC) #5
reed1
12 years, 1 month ago (2012-05-31 19:52:20 UTC) #6
lgtm

https://codereview.appspot.com/6250080/diff/4001/src/ports/SkFontHost_android...
File src/ports/SkFontHost_android.cpp (right):

https://codereview.appspot.com/6250080/diff/4001/src/ports/SkFontHost_android...
src/ports/SkFontHost_android.cpp:728: SkFontDescriptor descriptor;
:( do we not have the family name anywhere?
For playback on other platforms, the family name may be very useful
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b