its possible that we will want to make the read/write helpers be a little lower-level ...
12 years, 6 months ago
(2012-05-31 13:48:18 UTC)
#2
its possible that we will want to make the read/write helpers be a little
lower-level in the future (i.e just serialize to a byte-array like region and
matrix), but this is good for now.
lgtm
Lets just be sure to code the read/write methods to be open-ended about the number ...
12 years, 6 months ago
(2012-05-31 13:49:22 UTC)
#3
Lets just be sure to code the read/write methods to be open-ended about the
number of type of names in our first version. This will let us added more
descriptors in the future w/o invalidating old streams... (until that is too
ugly).
Other than the gyp nit, LGTM. http://codereview.appspot.com/6250080/diff/4001/gyp/ports.gyp File gyp/ports.gyp (right): http://codereview.appspot.com/6250080/diff/4001/gyp/ports.gyp#newcode23 gyp/ports.gyp:23: '../src/ports/SkFontDescriptor.cpp', '../src/ports/SkFontDescriptor.h', makes ...
12 years, 6 months ago
(2012-05-31 19:07:37 UTC)
#5
lgtm https://codereview.appspot.com/6250080/diff/4001/src/ports/SkFontHost_android.cpp File src/ports/SkFontHost_android.cpp (right): https://codereview.appspot.com/6250080/diff/4001/src/ports/SkFontHost_android.cpp#newcode728 src/ports/SkFontHost_android.cpp:728: SkFontDescriptor descriptor; :( do we not have the ...
12 years, 6 months ago
(2012-05-31 19:52:20 UTC)
#6
Issue 6250080: Add SkFontDescriptor for serializing fonts.
(Closed)
Created 12 years, 6 months ago by DerekS
Modified 12 years, 6 months ago
Reviewers: reed1, bungeman
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 2