Issue 6250070: special-case dashing a single line-segment. We can go much faster since we

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6250070: special-case dashing a single line-segment. We can go much faster since we (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by reed1

Modified:
12 years, 5 months ago

Reviewers:
bungeman, caryclark1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

special-case dashing a single line-segment. We can go much faster since we can apply the stroke as we go, eliminating the generic stroker. Committed: https://code.google.com/p/skia/source/detail?r=4062

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -2 lines)			Patch
	M	src/effects/SkDashPathEffect.cpp	View	1	4 chunks	+79 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

caryclark1

12 years, 5 months ago (2012-05-29 15:26:51 UTC) #3

lgtm

https://codereview.appspot.com/6250070/diff/1/src/effects/SkDashPathEffect.cpp
File src/effects/SkDashPathEffect.cpp (right):

https://codereview.appspot.com/6250070/diff/1/src/effects/SkDashPathEffect.cp...
src/effects/SkDashPathEffect.cpp:140: };
I'm sad that this is slower (I'll have to get out of the habit of writing code
this way)

Expand All Messages | Collapse All Messages