Issue 6250043: code review 6250043: flag: include flag name in redefinition panic.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6250043: code review 6250043: flag: include flag name in redefinition panic. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by dsymonds

Modified:
12 years, 9 months ago

Reviewers:

CC:
golang-dev, rsc, r

Visibility:
Public.

Description

flag: include flag name in redefinition panic.

Patch Set 2 : diff -r 00141c1d257a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 00141c1d257a https://go.googlecode.com/hg/ #

Total comments: 2

Patch Set 4 : diff -r 00141c1d257a https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 0baf69388fa5 https://go.googlecode.com/hg/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	src/pkg/flag/flag.go	View	1 2 3	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

dsymonds

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 9 months ago (2012-05-24 01:15:47 UTC) #1

dsymonds

On Thu, May 24, 2012 at 11:17 AM, Russ Cox <rsc@golang.org> wrote: > why does ...

12 years, 9 months ago (2012-05-24 01:23:07 UTC) #3

http://codereview.appspot.com/6250043/diff/4002/src/pkg/flag/flag.go File src/pkg/flag/flag.go (right): http://codereview.appspot.com/6250043/diff/4002/src/pkg/flag/flag.go#newcode624 src/pkg/flag/flag.go:624: panic("flag: redefinition of -" + name) // Happens only ...

12 years, 9 months ago (2012-05-24 02:36:36 UTC) #4

dsymonds

12 years, 9 months ago (2012-05-24 03:03:00 UTC) #5

dsymonds

12 years, 9 months ago (2012-05-24 03:42:10 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=64a249c65d51 ***

flag: include flag name in redefinition panic.

R=golang-dev, rsc, r
CC=golang-dev
http://codereview.appspot.com/6250043

Expand All Messages | Collapse All Messages