Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6)

Issue 6249073: We often rgn-diff an area >= the other rgn. now we detect that and return empty (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by reed1
Modified:
12 years, 6 months ago
Reviewers:
bungeman, TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

We often rgn-diff an area >= the other rgn. now we detect that and return empty We do this when we update our devices in SkCanvas.cpp Committed: https://code.google.com/p/skia/source/detail?r=4101

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -7 lines) Patch
M bench/RegionBench.cpp View 3 chunks +18 lines, -4 lines 1 comment Download
M include/core/SkRect.h View 1 2 chunks +16 lines, -2 lines 0 comments Download
M src/core/SkRegion.cpp View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 2
reed1
12 years, 6 months ago (2012-05-31 18:18:09 UTC) #1
TomH
12 years, 6 months ago (2012-05-31 18:23:15 UTC) #2
LGTM

https://codereview.appspot.com/6249073/diff/2001/bench/RegionBench.cpp
File bench/RegionBench.cpp (right):

https://codereview.appspot.com/6249073/diff/2001/bench/RegionBench.cpp#newcode35
bench/RegionBench.cpp:35: return result.op(a, a.getBounds(),
SkRegion::kDifference_Op);
Not even referring to b looks really odd - is it worth a comment?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b