Issue 6249064: Change engines order when global_engine is changed.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6249064: Change engines order when global_engine is changed. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by Peng

Modified:
12 years, 5 months ago

Reviewers:
fujiwara

Base URL:
git@github.com:/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Change engines order when global_engine is changed. BUG=http://code.google.com/p/ibus/issues/detail?id=1464 TEST=Manually

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : Fix review issues #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -14 lines)			Patch
	M	ui/gtk3/panel.vala	View	1 2	3 chunks	+31 lines, -14 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fujiwara

On 2012/05/29 12:36:54, Peng wrote: lgtm. I think it's good to update the dconf value ...

12 years, 6 months ago (2012-05-30 02:22:10 UTC) #2

Peng

12 years, 5 months ago (2012-05-30 15:38:27 UTC) #3

On 2012/05/30 02:22:10, fujiwara wrote:
> On 2012/05/29 12:36:54, Peng wrote:
> 
> lgtm.
> 
> I think it's good to update the dconf value 'engines_order' and also this
patch
> and Panel.switch_engine() could have the duplicated codes.

Fixed.

Expand All Messages | Collapse All Messages