Issue 6249044: code review 6249044: exp/html: detect "integration points" in SVG and MathML...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6249044: code review 6249044: exp/html: detect "integration points" in SVG and MathML... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by andybalholm

Modified:
12 years, 9 months ago

Reviewers:

CC:
nigeltao, golang-dev

Visibility:
Public.

Description

exp/html: detect "integration points" in SVG and MathML content Detect HTML integration points and MathML text integration points. At these points, process tokens as HTML, not as foreign content. Pass 33 more tests.

Patch Set 1 #

Patch Set 2 : diff -r 0baf69388fa5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 0baf69388fa5 https://go.googlecode.com/hg/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -37 lines)			Patch
M	src/pkg/exp/html/foreign.go	View	1	2 chunks	+21 lines, -2 lines	0 comments	Download
M	src/pkg/exp/html/parse.go	View	1	1 chunk	+18 lines, -2 lines	0 comments	Download
M	src/pkg/exp/html/testlogs/pending-spec-changes.dat.log	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/html/testlogs/plain-text-unsafe.dat.log	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download
M	src/pkg/exp/html/testlogs/tables01.dat.log	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/html/testlogs/tests10.dat.log	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
M	src/pkg/exp/html/testlogs/tests12.dat.log	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/exp/html/testlogs/tests19.dat.log	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
M	src/pkg/exp/html/testlogs/tests20.dat.log	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/pkg/exp/html/testlogs/tests26.dat.log	View	1	1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/pkg/exp/html/testlogs/tests9.dat.log	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/html/testlogs/webkit01.dat.log	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

andybalholm

Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 9 months ago (2012-05-24 01:58:30 UTC) #1

nigeltao

12 years, 9 months ago (2012-05-24 03:46:49 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=8c0f26decc1b ***

exp/html: detect "integration points" in SVG and MathML content

Detect HTML integration points and MathML text integration points.
At these points, process tokens as HTML, not as foreign content.

Pass 33 more tests.

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/6249044

Committer: Nigel Tao <nigeltao@golang.org>

Expand All Messages | Collapse All Messages