Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(869)

Issue 6248073: schema: fix Assert failures in a few tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by dave
Modified:
12 years, 6 months ago
Reviewers:
mp+108075, niemeyer
Visibility:
Public.

Description

schema: fix Assert failures in a few tests It appears the format of schema.Const values was altered a while back, causing the values printed in errors to fail. Ideally the error_.String() routine should be using %q, not %s but this would result in a much larger changeset. https://code.launchpad.net/~dave-cheney/juju/go-fix-schema-test/+merge/108075 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M schema/schema_test.go View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4
dave_cheney.net
Please take a look.
12 years, 6 months ago (2012-05-30 23:22:33 UTC) #1
dave_cheney.net
On 2012/05/30 23:22:33, dfc wrote: > Please take a look. <ping />
12 years, 6 months ago (2012-06-03 22:16:13 UTC) #2
niemeyer
On 2012/06/03 22:16:13, dfc wrote: > On 2012/05/30 23:22:33, dfc wrote: > > Please take ...
12 years, 6 months ago (2012-06-05 19:15:41 UTC) #3
niemeyer
12 years, 6 months ago (2012-06-05 19:31:01 UTC) #4
On 2012/06/05 19:15:41, niemeyer wrote:
> These tests aren't broken for me.. any idea of why you're getting those
> failures?

Found it. It's a change in Go's tip:

   changeset:   13342:23c7da226e28
   user:        Rob Pike <r@golang.org>
   date:        Tue May 29 15:08:08 2012 -0700
   summary:     fmt: speed up 10-20%

The schema code should either be made to pass in both tip and Go 1, or not
changed at this point.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b