Issue 6245050: dconf: don't regenerate 00-upstream-settings after intltool-merge

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6245050: dconf: don't regenerate 00-upstream-settings after intltool-merge (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by Daiki Ueno

Modified:
12 years, 1 month ago

Reviewers:
shawn.p.huang, fujiwara, Peng

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

dconf: don't regenerate 00-upstream-settings after intltool-merge BUG=https://codereview.appspot.com/6215062/#msg10 TEST=manually with make distcheck

Patch Set 1 #

Patch Set 2 : remove gsettings_SCHEMAS on make clean #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	data/dconf/Makefile.am	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fujiwara

On 2012/05/25 03:18:11, Daiki Ueno wrote: Looks good. I also think $(gsettings_SCHEMAS) is included in ...

12 years, 1 month ago (2012-05-25 03:25:36 UTC) #2

Peng

12 years, 1 month ago (2012-05-25 12:05:15 UTC) #3

On 2012/05/25 03:25:36, fujiwara wrote:
> On 2012/05/25 03:18:11, Daiki Ueno wrote:
> 
> Looks good.
> I also think $(gsettings_SCHEMAS) is included in CLEANFILES instead of
> DISTCLEANFILES not to delete Makefile.

lgtm

Expand All Messages | Collapse All Messages