On 2012/06/04 12:35:20, reed1 wrote: > It *seems* that fonthosts shouldn't have to know about ...
12 years, 6 months ago
(2012-06-04 13:42:47 UTC)
#6
On 2012/06/04 12:35:20, reed1 wrote:
> It *seems* that fonthosts shouldn't have to know about indices -vs- colors.
> Can't we just pre-discretize the color components (to have finite keys) and
give
> those to the Host, and then offer a single function
>
> ColorComponentToTable (or some other name)
>
> that returns a table given a color component?
This is more or less what was done in patch set 1 with cannonicalLuminance, but
I thought you didn't like that for some reason.
Initial ideas on piping the information down, both FreeType and GDI back-ends updated. CoreGraphics back-end ...
12 years, 5 months ago
(2012-06-27 17:55:24 UTC)
#7
Initial ideas on piping the information down, both FreeType and GDI back-ends
updated. CoreGraphics back-end shows a method that would be ideal if it were
publicly documented.
http://codereview.appspot.com/6244068/diff/13001/src/core/SkMaskGamma.h File src/core/SkMaskGamma.h (right): http://codereview.appspot.com/6244068/diff/13001/src/core/SkMaskGamma.h#newcode21 src/core/SkMaskGamma.h:21: should this be a Static method? http://codereview.appspot.com/6244068/diff/13001/src/core/SkMaskGamma.h#newcode22 src/core/SkMaskGamma.h:22: U8CPU ...
12 years, 5 months ago
(2012-06-27 18:22:31 UTC)
#8
By keeping the changes to gray on mac and linux behind the SK_GAMMA_APPLY_TO_A8, only minimal ...
12 years, 4 months ago
(2012-07-19 21:02:41 UTC)
#10
By keeping the changes to gray on mac and linux behind the SK_GAMMA_APPLY_TO_A8,
only minimal rebaselines will be needed with this change.
http://codereview.appspot.com/6244068/diff/32001/src/core/SkScalerContext.cpp
File src/core/SkScalerContext.cpp (right):
http://codereview.appspot.com/6244068/diff/32001/src/core/SkScalerContext.cpp...
src/core/SkScalerContext.cpp:593: applyLUTToA8Glyph(origGlyph,
fMaskPreBlend->fR);
One of the larger questions is, do we want to do this? In theory it's the right
thing to do. On the other hand it doesn't match current expectations, and green
shadows will look off. Also, this is applying contrast which we don't want to
do.
A similar (though weaker) argument can be made above, for the rasterizer case.
http://codereview.appspot.com/6244068/diff/32001/include/core/SkFontHost.h File include/core/SkFontHost.h (left): http://codereview.appspot.com/6244068/diff/32001/include/core/SkFontHost.h#oldcode234 include/core/SkFontHost.h:234: */ There are no callers of this function in ...
12 years, 4 months ago
(2012-07-23 12:36:18 UTC)
#13
https://codereview.appspot.com/6244068/diff/43001/include/core/SkScalerContext.h File include/core/SkScalerContext.h (left): https://codereview.appspot.com/6244068/diff/43001/include/core/SkScalerContext.h#oldcode80 include/core/SkScalerContext.h:80: #endif Is there a perf win to not make ...
12 years, 4 months ago
(2012-07-25 19:14:02 UTC)
#15
mostly requests for more clarity, some requests for code-sharing https://codereview.appspot.com/6244068/diff/44018/include/core/SkScalerContext.h File include/core/SkScalerContext.h (right): https://codereview.appspot.com/6244068/diff/44018/include/core/SkScalerContext.h#newcode26 include/core/SkScalerContext.h:26: ...
12 years, 4 months ago
(2012-07-27 14:29:07 UTC)
#17
I think I've gotten to all of the existing comments now. https://codereview.appspot.com/6244068/diff/44018/include/core/SkScalerContext.h File include/core/SkScalerContext.h (right): ...
12 years, 4 months ago
(2012-07-27 19:30:52 UTC)
#18
> This leaks if called repeatedly with different gamma exponents. True, but this cannot currently ...
12 years, 3 months ago
(2012-08-31 21:17:58 UTC)
#22
> This leaks if called repeatedly with different gamma exponents.
True, but this cannot currently happen. The code was written this way as a
stopping off point to show future intent. (This change was already rather
large.)
On the other hand this should be future proofed and we should free the resources
on Term. See https://codereview.appspot.com/6495071/
> so I guess it does happen somehow. I now understand why I haven't seen ...
12 years, 3 months ago
(2012-08-31 21:56:28 UTC)
#24
> so I guess it does happen somehow.
I now understand why I haven't seen this before. It doesn't happen in Skia, but
it does happen in Chrome. This is because Chrome does not define
SK_GAMMA_APPLY_TO_A8. When this is not defined, on Linux the regular
anti-aliased text is not gamma corrected, mostly because there is currently no
good means of re-base-lining the layout tests. I will need to re-think how
ignorePreBlend works or increase the cache size to 2.
I have opened http://code.google.com/p/skia/issues/detail?id=825 to track this.
Issue 6244068: Extract mask gamma; share more scaler contexts.
(Closed)
Created 12 years, 6 months ago by bungeman
Modified 12 years, 3 months ago
Reviewers: reed1, DerekS, thakis
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 81