Issue 6244057: Update setup ui file to gtk 3.0 and remove a debug print.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6244057: Update setup ui file to gtk 3.0 and remove a debug print. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by Peng

Modified:
12 years, 5 months ago

Reviewers:
fujiwara

Base URL:
git@github.com:/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Update setup ui file to gtk 3.0 and remove a debug print. BUG=None TEST=Manually

Patch Set 1 #

Patch Set 2 : Fix align issue #

Patch Set 3 : Update #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+161 lines, -31 lines)			Patch
	M	setup/enginecombobox.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	setup/setup.ui	View	1 2	62 chunks	+161 lines, -30 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

fujiwara

On 2012/05/28 02:43:42, Peng wrote: I think the alignments are not correct in "General" and ...

12 years, 6 months ago (2012-05-28 10:06:24 UTC) #2

Peng

On 2012/05/28 10:06:24, fujiwara wrote: > On 2012/05/28 02:43:42, Peng wrote: > > I think ...

12 years, 6 months ago (2012-05-28 13:49:59 UTC) #3

fujiwara

On 2012/05/28 13:49:59, Peng wrote: > On 2012/05/28 10:06:24, fujiwara wrote: > > On 2012/05/28 ...

12 years, 6 months ago (2012-05-29 08:55:31 UTC) #4

Peng

Update the CL again. Please check it. On 2012/05/29 08:55:31, fujiwara wrote: > On 2012/05/28 ...

12 years, 6 months ago (2012-05-29 12:06:32 UTC) #5

fujiwara

12 years, 6 months ago (2012-05-30 01:57:28 UTC) #6

On 2012/05/29 12:06:32, Peng wrote:
> Update the CL again. Please check it.
> 
> On 2012/05/29 08:55:31, fujiwara wrote:
> > On 2012/05/28 13:49:59, Peng wrote:
> > > On 2012/05/28 10:06:24, fujiwara wrote:
> > > > On 2012/05/28 02:43:42, Peng wrote:
> > > > 
> > > > I think the alignments are not correct in "General" and "Advanced" tabs:
> > > > http://fujiwara.fedorapeople.org/ibus/20120528/ibus-setup_2012-05-28.png
> > > 
> > > Fixed the align issue. Please check it again. Thanks
> > 
> > Not sure why you removed combobox_engines and treeview_engines and it causes
a
> > SEGV.
> 
> Seems it was removed by mistake. sorry for that.

lgtm.

Expand All Messages | Collapse All Messages