Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(304)

Issue 6244053: environs/ec2: remove unused madeBucket logic (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by dave
Modified:
13 years ago
Reviewers:
niemeyer, mp+107303
Visibility:
Public.

Description

environs/ec2: remove unused madeBucket logic storage.makeBucket sets s.madeBucket to true once PutBucket succeeds, but it never uses it to avoid calling PutBucket again. Indeed if you do skip the call to PutBucket when madeBucket is true, then the tests fail. https://code.launchpad.net/~dave-cheney/juju/master/+merge/107303 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/ec2: remove unused madeBucket logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M state/state.go View 1 1 chunk +1 line, -1 line 0 comments Download
M state/watcher_test.go View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
dave_cheney.net
Please take a look.
13 years ago (2012-05-24 23:11:28 UTC) #1
niemeyer
Sounds like something broke recently then. I'd prefer to see the bug fixed rather than ...
13 years ago (2012-05-25 01:16:09 UTC) #2
dave_cheney.net
After discussing this with Gustavo on IRC i'm going to abandon this fix, as it's ...
13 years ago (2012-05-25 01:38:01 UTC) #3
niemeyer
Sorry, false alarm. It's fine to remove it, here or as part of the other ...
13 years ago (2012-05-25 01:48:25 UTC) #4
dave_cheney.net
Please take a look.
13 years ago (2012-05-26 03:00:19 UTC) #5
dave_cheney.net
13 years ago (2012-05-26 03:00:48 UTC) #6
On 2012/05/26 03:00:19, dfc wrote:
> Please take a look.

Please ignore this.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b