environs/ec2: remove unused madeBucket logic

environs/ec2: remove unused madeBucket logic

storage.makeBucket sets s.madeBucket to true once 
PutBucket succeeds, but it never uses it to avoid
calling PutBucket again. Indeed if you do skip the
call to PutBucket when madeBucket is true, then the
tests fail.

https://code.launchpad.net/~dave-cheney/juju/master/+merge/107303

(do not edit description out of merge proposal)

[dave_cheney.net, 2012-05-24 23:11:28]

Please take a look.

[niemeyer, 2012-05-25 01:16:09]

Sounds like something broke recently then. I'd prefer to see the bug fixed
rather than incurring in an extra call to PutBucket every single time we try to
put a file in the bucket.

Note that in addition to checking madeBucket on PutBucket, it needs to be reset
when the state is deleted, otherwise tests should indeed fail (delete all state
+ put bucket should be == make bucket again).

[dave_cheney.net, 2012-05-25 01:38:01]

After discussing this with Gustavo on IRC i'm going to abandon this fix, as it's
actually a bigger amount of work than I expected.

[niemeyer, 2012-05-25 01:48:25]

Sorry, false alarm. It's fine to remove it, here or as part of the other branch.
madeBucket was born broken.

[dave_cheney.net, 2012-05-26 03:00:19]

Please take a look.

[dave_cheney.net, 2012-05-26 03:00:48]

On 2012/05/26 03:00:19, dfc wrote:
> Please take a look.

Please ignore this.