code review 6243045: net/mail: more liberal parsing of Date headers.

net/mail: more liberal parsing of Date headers.
Fixes issue 3639.

[wathiede, 2012-05-24 03:55:15]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
file:///storage/zroot/usr/home/wathiede/Downloads/go-fixes

[wathiede, 2012-05-24 04:00:16]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[dsymonds, 2012-05-24 06:00:31]

Please update the CL description to read as such:
  net/mail: more liberal parsing of Date headers.

http://codereview.appspot.com/6243045/diff/2003/src/pkg/net/mail/message.go
File src/pkg/net/mail/message.go (right):

http://codereview.appspot.com/6243045/diff/2003/src/pkg/net/mail/message.go#n...
src/pkg/net/mail/message.go:76: zones := [...]string{"-0700", "MST", "-0700
(MST)"} // zone = (("+" / "-") 4DIGIT) / "GMT" / ...
put a comment above this line:
  // "-0700 (MST)" is not in RFC 5322, but is common.

http://codereview.appspot.com/6243045/diff/2003/src/pkg/net/mail/message_test.go
File src/pkg/net/mail/message_test.go (right):

http://codereview.appspot.com/6243045/diff/2003/src/pkg/net/mail/message_test...
src/pkg/net/mail/message_test.go:93: "Fri, 21 Nov 1997 09:55:06 -0600 (MDT)",
This is not in RFC 5322. Please make it its own test case with an appropriate
comment.

[dsymonds, 2012-05-24 06:02:32]

Also, please fill out the CLA (http://golang.org/doc/contribute.html#copyright),
and let me know when you've done so.

[wathiede, 2012-05-24 17:51:40]

Hello golang-dev@googlegroups.com, dsymonds@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[wathiede, 2012-05-24 17:52:50]

On 2012/05/24 06:02:32, dsymonds wrote:
> Also, please fill out the CLA
(http://golang.org/doc/contribute.html#copyright),
> and let me know when you've done so.

If I work for Google do I still need to fill one out?  My username is wathiede

[dsymonds, 2012-05-24 22:57:59]

On Fri, May 25, 2012 at 3:52 AM,  <couchmoney@gmail.com> wrote:

> If I work for Google do I still need to fill one out?  My username is
wathiede

You don't. I didn't realise. I'll take care of it.

[dsymonds, 2012-05-24 23:11:58]

LGTM

I'll submit after we've sorted the C&A.

[dsymonds, 2012-05-24 23:19:29]

*** Submitted as http://code.google.com/p/go/source/detail?r=e995a1bfe589 ***

net/mail: more liberal parsing of Date headers.
Fixes issue 3639.

R=golang-dev, dsymonds
CC=golang-dev
http://codereview.appspot.com/6243045

Committer: David Symonds <dsymonds@golang.org>