Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(247)

Issue 6242071: skdiff: return nonzero exit value if there are any mismatches (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by epoger
Modified:
12 years, 4 months ago
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

skdiff: return nonzero exit value if there are any mismatches This will allow us to replace "gm -r" in our buildbots with "skdiff". This will speed things up, and work around http://code.google.com/p/skia/issues/detail?id=473 ('PDF gradtext gm image results are nondeterministic') Committed: https://code.google.com/p/skia/source/detail?r=4097

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M tools/skdiff_main.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/tests/skdiff/test1/output-expected/return_value View 1 chunk +1 line, -1 line 0 comments Download
M tools/tests/skdiff/test2/output-expected/return_value View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
epoger
12 years, 4 months ago (2012-05-30 19:25:20 UTC) #1
epoger
P.S. Tom- I've been sending all these skdiff reviews to you, because you wrote it ...
12 years, 4 months ago (2012-05-30 19:30:15 UTC) #2
(pls use tomhudson at google)
12 years, 4 months ago (2012-05-31 14:46:46 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b