Issue 6242057: Detect when the caller was hairline AND strokeandfill, and resolve that into FILL

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6242057: Detect when the caller was hairline AND strokeandfill, and resolve that into FILL (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by reed1

Modified:
12 years, 7 months ago

Reviewers:
bungeman, epoger

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Detect when the caller was hairline AND strokeandfill, and resolve that into FILL This fixes the unittests on WIN in the trybot for DEPS roll 4048 Committed: https://code.google.com/p/skia/source/detail?r=4057

Patch Set 1 #

Total comments: 2

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -9 lines)			Patch
M	include/core/SkPathEffect.h	View	1 chunk	+9 lines, -7 lines	1 comment	Download
M	src/core/SkPathEffect.cpp	View	2 chunks	+24 lines, -2 lines	1 comment	Download
M	tests/PathTest.cpp	View	2 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

epoger

LGTM https://codereview.appspot.com/6242057/diff/1/include/core/SkPathEffect.h File include/core/SkPathEffect.h (right): https://codereview.appspot.com/6242057/diff/1/include/core/SkPathEffect.h#newcode54 include/core/SkPathEffect.h:54: * Note, if width==0, then this request is ...

12 years, 7 months ago (2012-05-25 13:32:17 UTC) #2

LGTM

Expand All Messages | Collapse All Messages