Issue 6242045: Implemented #extension and #version directives.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6242045: Implemented #extension and #version directives. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by Alok Priyadarshi

Modified:
13 years, 10 months ago

Reviewers:
kbr1

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Implemented #extension and #version directives. Committed: https://code.google.com/p/angleproject/source/detail?r=1095

Patch Set 1 #

Total comments: 1

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+371 lines, -12 lines)			Patch
M	src/compiler/preprocessor/new/Diagnostics.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/compiler/preprocessor/new/DirectiveHandler.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/compiler/preprocessor/new/DirectiveParser.cpp	View	8 chunks	+112 lines, -11 lines	0 comments	Download
M	tests/build_tests.gyp	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	tests/preprocessor_tests/MockDirectiveHandler.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
A	tests/preprocessor_tests/extension_test.cpp	View	1 chunk	+121 lines, -0 lines	0 comments	Download
A	tests/preprocessor_tests/version_test.cpp	View	1 chunk	+115 lines, -0 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

kbr1

13 years, 10 months ago (2012-05-24 16:20:20 UTC) #2

LGTM

I agree with your comment on the last code review that the tests should be
refactored to introduce a base class holding the Diagnostics, DirectiveHandler
and other objects.

https://codereview.appspot.com/6242045/diff/1/tests/preprocessor_tests/versio...
File tests/preprocessor_tests/version_test.cpp (right):

https://codereview.appspot.com/6242045/diff/1/tests/preprocessor_tests/versio...
tests/preprocessor_tests/version_test.cpp:38: // No handlePragma calls.
Stale comment?

Expand All Messages | Collapse All Messages