Issue 6241043: Adds special cases to the taming membrane for builtins.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6241043: Adds special cases to the taming membrane for builtins. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by metaweta

Modified:
13 years, 10 months ago

Reviewers:
felix8a, ihab.awad

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Adds special cases for Boolean, Date, Number, RegExp, and String to the taming membrane. Also whitelists toString and valueOf on Boolean.prototype. (No one ever noticed they were missing.)

Patch Set 1 #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -6 lines)			Patch
M	src/com/google/caja/es53.js	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/com/google/caja/plugin/taming-membrane.js	View	1 chunk	+13 lines, -2 lines	0 comments	Download
M	tests/com/google/caja/plugin/es53-test-taming-untamed-guest.html	View	1 chunk	+11 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lgtm

Expand All Messages | Collapse All Messages