Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(480)

Issue 6228049: code review 6228049: exp/html: update test data (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by andybalholm
Modified:
12 years, 9 months ago
Reviewers:
CC:
nigeltao, golang-dev
Visibility:
Public.

Description

exp/html: update test data Import updated test data from the WebKit Subversion repository (SVN revision 118111). Some of the old tests were failing because we were HTML5 compliant, but the tests weren't.

Patch Set 1 #

Patch Set 2 : diff -r 1098c239b9ad https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1098c239b9ad https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -16 lines) Patch
M src/pkg/exp/html/testdata/webkit/pending-spec-changes.dat View 1 1 chunk +24 lines, -0 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/plain-text-unsafe.dat View 1 Binary file 0 comments Download
M src/pkg/exp/html/testdata/webkit/tables01.dat View 1 1 chunk +15 lines, -0 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests16.dat View 1 1 chunk +22 lines, -0 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests19.dat View 1 5 chunks +21 lines, -4 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests26.dat View 1 1 chunk +118 lines, -0 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/tests_innerHTML_1.dat View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/webkit01.dat View 1 3 chunks +6 lines, -5 lines 0 comments Download
M src/pkg/exp/html/testdata/webkit/webkit02.dat View 1 1 chunk +55 lines, -0 lines 0 comments Download
M src/pkg/exp/html/testlogs/pending-spec-changes.dat.log View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/exp/html/testlogs/plain-text-unsafe.dat.log View 1 1 chunk +32 lines, -0 lines 0 comments Download
M src/pkg/exp/html/testlogs/tables01.dat.log View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/exp/html/testlogs/tests16.dat.log View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/exp/html/testlogs/tests19.dat.log View 1 2 chunks +5 lines, -4 lines 0 comments Download
M src/pkg/exp/html/testlogs/tests26.dat.log View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/pkg/exp/html/testlogs/tests_innerHTML_1.dat.log View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/exp/html/testlogs/webkit01.dat.log View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/exp/html/testlogs/webkit02.dat.log View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5
andybalholm
Hello nigeltao@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 9 months ago (2012-05-23 04:47:30 UTC) #1
nigeltao
Can you update the change description with the WebKit svn revision number? I think "svn ...
12 years, 9 months ago (2012-05-23 06:44:44 UTC) #2
andybalholm
On May 22, 2012, at 11:44 PM, nigeltao@golang.org wrote: > Can you update the change ...
12 years, 9 months ago (2012-05-23 14:52:49 UTC) #3
nigeltao
LGTM.
12 years, 9 months ago (2012-05-24 00:33:24 UTC) #4
nigeltao
12 years, 9 months ago (2012-05-24 00:35:40 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=00141c1d257a ***

exp/html: update test data

Import updated test data from the WebKit Subversion repository (SVN revision
118111).

Some of the old tests were failing because we were HTML5 compliant, but the
tests weren't.

R=nigeltao
CC=golang-dev
http://codereview.appspot.com/6228049

Committer: Nigel Tao <nigeltao@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b