Issue 6228047: code review 6228047: godoc: correctly categorize interface methods, performa...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6228047: code review 6228047: godoc: correctly categorize interface methods, performa... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by gri

Modified:
12 years, 9 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

godoc: correctly categorize interface methods, performance tuning - interface methods appeared under VarDecl in search results (long-standing TODO) - don't walk parts of AST which contain no indexable material (minor performance tuning)

Patch Set 1 #

Patch Set 2 : diff -r 4c05c319570b https://code.google.com/p/go #

Patch Set 3 : diff -r 4c05c319570b https://code.google.com/p/go #

Patch Set 4 : diff -r 4c05c319570b https://code.google.com/p/go #

Patch Set 5 : diff -r 0dc36a693538 https://code.google.com/p/go #

Patch Set 6 : diff -r 0dc36a693538 https://code.google.com/p/go #

Patch Set 7 : diff -r 0dc36a693538 https://code.google.com/p/go #

Patch Set 8 : diff -r 0dc36a693538 https://code.google.com/p/go #

Patch Set 9 : diff -r 0dc36a693538 https://code.google.com/p/go #

Patch Set 10 : diff -r 3b320ce16e39 https://code.google.com/p/go #

Patch Set 11 : diff -r fc0c9f4f74b6 https://code.google.com/p/go #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -48 lines)			Patch
	M	src/cmd/godoc/index.go	View	1 2 3 4 5 6 7 8 9	6 chunks	+36 lines, -48 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

12 years, 9 months ago (2012-05-23 00:53:11 UTC) #1

gri

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 9 months ago (2012-05-23 17:28:47 UTC) #2

gri

12 years, 9 months ago (2012-05-24 17:56:39 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=dc9e8cac5622 ***

godoc: correctly categorize interface methods, performance tuning

- interface methods appeared under VarDecl in search results
  (long-standing TODO)

- don't walk parts of AST which contain no indexable material
  (minor performance tuning)

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6228047

Expand All Messages | Collapse All Messages