download_baselines.py : only set svn properties of files whose content has changed

download_baselines.py : only set svn properties of files whose content has changed

and while I was at it, sort the filenames before acting on them, to make the output easier to read

BUG=http://code.google.com/p/skia/issues/detail?id=618
Committed: https://code.google.com/p/skia/source/detail?r=4031

[epoger, 2012-05-22 16:06:07]

first LG wins

[robertphillips, 2012-05-22 18:15:22]

A question:

http://codereview.appspot.com/6223061/diff/1/tools/download_baselines.py
File tools/download_baselines.py (right):

http://codereview.appspot.com/6223061/diff/1/tools/download_baselines.py#newc...
tools/download_baselines.py:121: modified_files =
repo_to_modify.GetNewAndModifiedFiles()
Why aren't you just calling SetPropertyByFilenamePattern on modified_files here?

[epoger, 2012-05-22 19:01:42]

http://codereview.appspot.com/6223061/diff/1/tools/download_baselines.py
File tools/download_baselines.py (right):

http://codereview.appspot.com/6223061/diff/1/tools/download_baselines.py#newc...
tools/download_baselines.py:121: modified_files =
repo_to_modify.GetNewAndModifiedFiles()
On 2012/05/22 18:15:22, robertphillips wrote:
> Why aren't you just calling SetPropertyByFilenamePattern on modified_files
here?

We could augment SetPropertyByFilenamePattern to take both a list of files and a
pattern to filter down that list... but currently, it only takes the pattern
(which is then applied to *all* files, as the code was doing before this
change).

Do you think it would be cleaner to make another version of
SetPropertyByFilenamePattern, rather than doing the filtering in this code?

[robertphillips, 2012-05-22 19:11:20]

LGTM