Issue 6222045: Remove chromium mode from skdiff, because it is no longer actively used.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6222045: Remove chromium mode from skdiff, because it is no longer actively used. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by epoger

Modified:
12 years, 7 months ago

Reviewers:
caryclark1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Remove chromium mode from skdiff, because it is no longer actively used. Ran tools/tests/run.sh to validate this change. TBR=caryclark1 Committed: https://code.google.com/p/skia/source/detail?r=4005

Patch Set 1 #

Total comments: 1

Created: 12 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -132 lines)			Patch
	M	tools/skdiff_main.cpp	View		10 chunks	+6 lines, -132 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

epoger

12 years, 7 months ago (2012-05-18 17:54:51 UTC) #1

https://codereview.appspot.com/6222045/diff/1/tools/skdiff_main.cpp
File tools/skdiff_main.cpp (left):

https://codereview.appspot.com/6222045/diff/1/tools/skdiff_main.cpp#oldcode79
tools/skdiff_main.cpp:79: // These asserts are valid for GM, but not for
--chromium
Actually, these asserts aren't valid in any mode.  They will fail if any file is
present in baseDir but missing in comparisonDir (or vice-versa).

Expand All Messages | Collapse All Messages