Issue 622041: code review 622041: syscall: mksyscall_mingw.sh emitting shorter calls (to ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 622041: code review 622041: syscall: mksyscall_mingw.sh emitting shorter calls (to ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 10 months ago by brainman

Modified:
14 years, 10 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

syscall: mksyscall_mingw.sh emitting shorter calls (to Syscall or Syscall6) when there are fewer arguments

Patch Set 1 #

Patch Set 2 : code review 622041: syscall: mksyscall_mingw.sh emitting shorter calls (to ... #

Patch Set 3 : code review 622041: syscall: mksyscall_mingw.sh emitting shorter calls (to ... #

Created: 14 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -23 lines)			Patch
M	src/pkg/runtime/mingw/syscall.cgo	View	2 chunks	+12 lines, -15 lines	0 comments	Download
M	src/pkg/syscall/mksyscall_mingw.sh	View	2 chunks	+13 lines, -3 lines	0 comments	Download
M	src/pkg/syscall/zsyscall_mingw_386.go	View	4 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change.

14 years, 10 months ago (2010-03-18 01:52:15 UTC) #1

brainman

On 2010/03/19 19:53:44, rsc1 wrote: > LGTM > I just realized now, I didn't change ...

14 years, 10 months ago (2010-03-19 21:00:37 UTC) #4

brainman

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 10 months ago (2010-03-19 21:25:06 UTC) #5

rsc

14 years, 10 months ago (2010-03-19 22:17:20 UTC) #7

*** Submitted as http://code.google.com/p/go/source/detail?r=13dfd1ffe519 ***

syscall: mksyscall_mingw.sh emitting shorter calls (to Syscall or Syscall6) when
there are fewer arguments

R=rsc
CC=golang-dev
http://codereview.appspot.com/622041

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages