Issue 6220044: test-only change: update run.sh and rearrange dirs to ease addition of more tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6220044: test-only change: update run.sh and rearrange dirs to ease addition of more tests (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by epoger

Modified:
12 years, 3 months ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

test-only change: update run.sh and rearrange dirs to ease addition of more tests Committed: https://code.google.com/p/skia/source/detail?r=3995

Patch Set 1 #

Total comments: 1

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -55 lines)			Patch
M	tools/tests/run.sh	View	2 chunks	+20 lines, -9 lines	1 comment	Download
D	tools/tests/skdiff/output-expected/index.html	View	1 chunk	+0 lines, -30 lines	0 comments	Download
D	tools/tests/skdiff/output-expected/slightly-different-pixels-same-size-diff.png	View	Binary file		0 comments	Download
D	tools/tests/skdiff/output-expected/slightly-different-pixels-same-size-white.png	View	Binary file		0 comments	Download
D	tools/tests/skdiff/output-expected/stdout	View	1 chunk	+0 lines, -16 lines	0 comments	Download
D	tools/tests/skdiff/output-expected/very-different-pixels-same-size-diff.png	View	Binary file		0 comments	Download
D	tools/tests/skdiff/output-expected/very-different-pixels-same-size-white.png	View	Binary file		0 comments	Download
A	tools/tests/skdiff/test1/output-expected/index.html	View	1 chunk	+30 lines, -0 lines	0 comments	Download
A	tools/tests/skdiff/test1/output-expected/slightly-different-pixels-same-size-diff.png	View	Binary file		0 comments	Download
A	tools/tests/skdiff/test1/output-expected/slightly-different-pixels-same-size-white.png	View	Binary file		0 comments	Download
A	tools/tests/skdiff/test1/output-expected/stdout	View	1 chunk	+16 lines, -0 lines	0 comments	Download
A	tools/tests/skdiff/test1/output-expected/very-different-pixels-same-size-diff.png	View	Binary file		0 comments	Download
A	tools/tests/skdiff/test1/output-expected/very-different-pixels-same-size-white.png	View	Binary file		0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

TomH

12 years, 3 months ago (2012-05-17 16:55:00 UTC) #2

LGTM

https://codereview.appspot.com/6220044/diff/1/tools/tests/run.sh
File tools/tests/run.sh (right):

https://codereview.appspot.com/6220044/diff/1/tools/tests/run.sh#newcode14
tools/tests/run.sh:14: # Otherwise, we write nothing to stdout and return.
Yay!

Expand All Messages | Collapse All Messages