Issue 6219057: code review 6219057: crypto/ecdsa: fix case where p != 0 mod 8 and the hash ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6219057: code review 6219057: crypto/ecdsa: fix case where p != 0 mod 8 and the hash ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by agl1

Modified:
12 years, 9 months ago

Reviewers:

CC:
golang-dev, rsc1

Visibility:
Public.

Description

crypto/ecdsa: fix case where p != 0 mod 8 and the hash length < p. I made a typo which breaks P-521.

Patch Set 1 #

Patch Set 2 : diff -r 46cb8b1a05d8 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 46cb8b1a05d8 https://code.google.com/p/go/ #

Patch Set 4 : diff -r da5b554f6ea6 https://code.google.com/p/go/ #

Patch Set 5 : diff -r da5b554f6ea6 https://code.google.com/p/go/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/pkg/crypto/ecdsa/ecdsa.go	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

agl1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 9 months ago (2012-05-21 22:32:11 UTC) #1

agl1

On Mon, May 21, 2012 at 6:45 PM, Russ Cox <rsc@google.com> wrote: > LGTM. Test? ...

12 years, 9 months ago (2012-05-21 23:12:39 UTC) #3

agl1

12 years, 9 months ago (2012-05-22 14:17:55 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=465e0f78dbfe ***

crypto/ecdsa: fix case where p != 0 mod 8 and the hash length < p.

I made a typo which breaks P-521.

R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6219057

Expand All Messages | Collapse All Messages