code review 6218072: syscall: simplify text returned by Errno.Error() when F...

syscall: simplify text returned by Errno.Error() when FormatMessage fails

Fixes issue 3623.

[brainman, 2012-05-23 07:21:24]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bsiegert, 2012-05-23 08:36:56]

I would like to see the TODO resolved instead.

My Windows installation is in German, and most of the syscall errors I get look
like this:

2012/05/23 10:05:50 WSARecv tcp 127.0.0.1:80: error 64 (FormatMessage failed
with err=1815)

[brainman, 2012-05-24 02:20:52]

On 2012/05/23 08:36:56, bsiegert wrote:
> I would like to see the TODO resolved instead.
> 

Me too, but it is not resolved yet. I am not yet certain, it can be resolved.
Feel free to send fixes.

> My Windows installation is in German, and most of the syscall errors I get
look
> like this:
> 
> 2012/05/23 10:05:50 WSARecv tcp 127.0.0.1:80: error 64 (FormatMessage failed
> with err=1815)

I know. I feel, "FormatMessage ..." bit is just an unhelpful distraction for
user that got an error and is trying to understand what happened. So, I want to
change it to:

2012/05/23 10:05:50 WSARecv tcp 127.0.0.1:80: winapi error #64

I never had problem with FormatMessage myself, and I originally put
"FormatMessage ...", so I could see when and why it fails for others. I do know
now, and it is not very helpful :-). Nothing I can do about it. So I decided to
get rid of it.

Alex

[rsc, 2012-05-24 15:39:45]

LGTM

[rsc, 2012-05-24 15:43:43]

I think 3376 should not be too hard.  The code that initializes an
os.File should call GetConsoleMode to determine whether the underlying
handle is in fact the console.  If so, the Write method should use
WriteConsoleW instead of the usual write.  It will need to save a
trailing partial UTF-8 sequence in a small buffer for adding to the
next write.

Russ

[brainman, 2012-05-27 08:57:27]

*** Submitted as http://code.google.com/p/go/source/detail?r=ac7250065a04 ***

syscall: simplify text returned by Errno.Error() when FormatMessage fails

Fixes issue 3623.

R=golang-dev, bsiegert, rsc
CC=golang-dev
http://codereview.appspot.com/6218072