Issue 6215072: Implemented #define and #undef directives.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6215072: Implemented #define and #undef directives. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by Alok Priyadarshi

Modified:
13 years, 10 months ago

Reviewers:
kbr1

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Implemented #define and #undef directives. Committed: https://code.google.com/p/angleproject/source/detail?r=1092

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+146 lines, -70 lines)			Patch
M	src/build_angle.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/compiler/preprocessor/new/Diagnostics.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/compiler/preprocessor/new/DirectiveParser.h	View		3 chunks	+5 lines, -1 line	0 comments	Download
M	src/compiler/preprocessor/new/DirectiveParser.cpp	View	1	6 chunks	+96 lines, -10 lines	0 comments	Download
M	src/compiler/preprocessor/new/Macro.h	View		2 chunks	+12 lines, -25 lines	0 comments	Download
M	src/compiler/preprocessor/new/Macro.cpp	View		1 chunk	+6 lines, -28 lines	0 comments	Download
M	src/compiler/preprocessor/new/MacroExpander.h	View		3 chunks	+3 lines, -1 line	0 comments	Download
M	src/compiler/preprocessor/new/MacroExpander.cpp	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	src/compiler/preprocessor/new/Preprocessor.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/compiler/preprocessor/new/Preprocessor.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/compiler/preprocessor/new/Token.h	View		2 chunks	+11 lines, -1 line	0 comments	Download

Total messages: 2

LGTM