Issue 6213066: Implemented #error and #pragma directives. Added new tests and updated old ones for the new preproc…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6213066: Implemented #error and #pragma directives. Added new tests and updated old ones for the new preproc… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by Alok Priyadarshi

Modified:
11 years, 11 months ago

Reviewers:
kbr1

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Implemented #error and #pragma directives. Added new tests and updated old ones for the new preprocessor API. Committed: https://code.google.com/p/angleproject/source/detail?r=1094

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+457 lines, -30 lines)			Patch
M	src/build_angle.gyp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/compiler/preprocessor/new/Diagnostics.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	src/compiler/preprocessor/new/DirectiveHandler.h	View	1	1 chunk	+36 lines, -0 lines	1 comment	Download
A	src/compiler/preprocessor/new/DirectiveHandler.cpp	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	src/compiler/preprocessor/new/DirectiveParser.h	View		3 chunks	+4 lines, -1 line	0 comments	Download
M	src/compiler/preprocessor/new/DirectiveParser.cpp	View	1 2	3 chunks	+65 lines, -4 lines	0 comments	Download
M	src/compiler/preprocessor/new/Preprocessor.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	src/compiler/preprocessor/new/Preprocessor.cpp	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	tests/build_tests.gyp	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	tests/preprocessor_tests/MockDirectiveHandler.h	View	1	1 chunk	+25 lines, -0 lines	0 comments	Download
M	tests/preprocessor_tests/char_test.cpp	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	tests/preprocessor_tests/comment_test.cpp	View		4 chunks	+7 lines, -3 lines	0 comments	Download
A	tests/preprocessor_tests/error_test.cpp	View	1 2	1 chunk	+110 lines, -0 lines	0 comments	Download
M	tests/preprocessor_tests/identifier_test.cpp	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	tests/preprocessor_tests/input_test.cpp	View		2 chunks	+7 lines, -3 lines	0 comments	Download
M	tests/preprocessor_tests/location_test.cpp	View		3 chunks	+6 lines, -2 lines	0 comments	Download
M	tests/preprocessor_tests/number_test.cpp	View		4 chunks	+7 lines, -3 lines	0 comments	Download
M	tests/preprocessor_tests/operator_test.cpp	View		2 chunks	+3 lines, -1 line	0 comments	Download
A	tests/preprocessor_tests/pragma_test.cpp	View	1 2	1 chunk	+144 lines, -0 lines	0 comments	Download
M	tests/preprocessor_tests/space_test.cpp	View		4 chunks	+7 lines, -3 lines	0 comments	Download
M	tests/preprocessor_tests/token_test.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Alok Priyadarshi

Sorry for the large patch, but you can skim through most of the changes to ...

11 years, 11 months ago (2012-05-23 21:44:31 UTC) #1

kbr1

11 years, 11 months ago (2012-05-23 23:23:55 UTC) #2

LGTM

http://codereview.appspot.com/6213066/diff/4001/src/compiler/preprocessor/new...
File src/compiler/preprocessor/new/DirectiveHandler.h (right):

http://codereview.appspot.com/6213066/diff/4001/src/compiler/preprocessor/new...
src/compiler/preprocessor/new/DirectiveHandler.h:20: // handling them in an
appropriate manner.
grammar: "interpreting handling"

Expand All Messages | Collapse All Messages