Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1346)

Issue 6213060: remove bogus nearlyzero checks (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 4 months ago by reed1
Modified:
12 years, 4 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

remove bogus nearlyzero checks Committed: https://code.google.com/p/skia/source/detail?r=4014

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M gm/base-macpro/dashing_4444.png View 1 Binary file 0 comments Download
M gm/base-macpro/dashing_565.png View 1 Binary file 0 comments Download
M gm/base-macpro/dashing_8888.png View 1 Binary file 0 comments Download
M gm/base-macpro/dashing_gpu.png View 1 Binary file 0 comments Download
M gm/base-macpro/dashing_msaa16.png View 1 Binary file 0 comments Download
M gm/base-macpro/dashing_pdf.png View 1 Binary file 0 comments Download
M gm/dashing.cpp View 1 3 chunks +14 lines, -2 lines 0 comments Download
M src/core/SkPathMeasure.cpp View 3 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 4
reed1
2 svg layouttest failures related to this (on linux) svg/transforms/svg-css-transforms.xhtml transforms/svg-vs-css.xhtml Both cases show single ...
12 years, 4 months ago (2012-05-21 16:32:24 UTC) #1
epoger
Why no reviewers on this CL that affects visible behavior?
12 years, 4 months ago (2012-05-23 15:32:23 UTC) #2
reed1
On 2012/05/23 15:32:23, epoger wrote: > Why no reviewers on this CL that affects visible ...
12 years, 4 months ago (2012-05-23 17:04:36 UTC) #3
epoger
12 years, 4 months ago (2012-05-23 17:15:31 UTC) #4
On 2012/05/23 17:04:36, reed1 wrote:
> On 2012/05/23 15:32:23, epoger wrote:
> > Why no reviewers on this CL that affects visible behavior?
> 
> It did not affect visible behavior.

Well, the layout test differences seem to indicate that this *did* change
visible behavior.

But I shouldn't have muddied the water with the visibility aspect... why not get
changes reviewed *in general*?  Isn't code review a healthy thing in most
circumstances?

> I am very interested in understanding what the chrome unittests are actually
> producing, and will follow up on that when I'm back tomorrow (if vandebo
doesn't
> figure it out first).

If you are referring to http://crbug.com/129331 ('VectorCanvasTest.PathEffects
fails on WebKit Win (deps)'), I'm working on it. (Although so far, I have been
blocked on rather pedestrian issues around updating my Chrome tree.)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b