Issue 6213057: code review 6213057: runtime: support conditional execution in ARM softfloat

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6213057: code review 6213057: runtime: support conditional execution in ARM softfloat (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by minux1

Modified:
12 years, 9 months ago

Reviewers:

CC:
golang-dev, dave_cheney.net, rsc

Visibility:
Public.

Description

runtime: support conditional execution in ARM softfloat Fixes issue 3638.

Patch Set 1 #

Patch Set 2 : diff -r 3c702dae5f50 https://code.google.com/p/go/ #

Patch Set 3 : diff -r fa807f847959 https://code.google.com/p/go/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -6 lines)			Patch
	M	src/pkg/runtime/softfloat_arm.c	View	1	3 chunks	+59 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 10 months ago (2012-05-19 19:08:06 UTC) #1

dave_cheney.net

Hello. This worked for me on arm5, thank you. stora(~) % cat /proc/cpuinfo Processor : ...

12 years, 10 months ago (2012-05-20 05:13:07 UTC) #2

minux1

12 years, 9 months ago (2012-05-22 18:00:49 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=87ef5e0baaf5 ***

runtime: support conditional execution in ARM softfloat
        Fixes issue 3638.

R=golang-dev, dave, rsc
CC=golang-dev
http://codereview.appspot.com/6213057

Expand All Messages | Collapse All Messages