Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(32)

Issue 6212048: Improved the language of a couple of dialogs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by Daiki Ueno
Modified:
12 years, 6 months ago
Reviewers:
shawn.p.huang, majora700
CC:
majora700_gmail.com, fujiwara
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Improved the language of a couple of dialogs. Also update all po files. BUG=https://github.com/ibus/ibus/pull/4 TEST=manually

Patch Set 1 #

Patch Set 2 : update po files #

Patch Set 3 : update po files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14252 lines, -13451 lines) Patch
M po/ar.po View 1 2 2 chunks +363 lines, -343 lines 0 comments Download
M po/as.po View 1 2 3 chunks +396 lines, -381 lines 0 comments Download
M po/bn_IN.po View 1 2 4 chunks +404 lines, -363 lines 0 comments Download
M po/ca.po View 1 2 3 chunks +411 lines, -393 lines 0 comments Download
M po/da.po View 1 2 3 chunks +401 lines, -381 lines 0 comments Download
M po/de.po View 1 2 3 chunks +413 lines, -392 lines 0 comments Download
M po/en_GB.po View 1 2 2 chunks +400 lines, -381 lines 0 comments Download
M po/es.po View 1 2 3 chunks +419 lines, -398 lines 0 comments Download
M po/fa.po View 1 2 2 chunks +292 lines, -307 lines 0 comments Download
M po/fr.po View 1 2 3 chunks +416 lines, -397 lines 0 comments Download
M po/gu.po View 1 2 2 chunks +397 lines, -379 lines 0 comments Download
M po/hi.po View 1 2 2 chunks +397 lines, -377 lines 0 comments Download
M po/hu.po View 1 2 3 chunks +415 lines, -393 lines 0 comments Download
M po/it.po View 1 2 3 chunks +412 lines, -371 lines 0 comments Download
M po/ja.po View 1 2 2 chunks +412 lines, -380 lines 0 comments Download
M po/kn.po View 1 2 4 chunks +398 lines, -383 lines 0 comments Download
M po/ko.po View 1 2 3 chunks +402 lines, -361 lines 0 comments Download
M po/lv.po View 1 2 2 chunks +412 lines, -390 lines 0 comments Download
M po/ml.po View 1 2 4 chunks +402 lines, -361 lines 0 comments Download
M po/mr.po View 1 2 2 chunks +398 lines, -379 lines 0 comments Download
M po/nl.po View 1 2 3 chunks +405 lines, -385 lines 0 comments Download
M po/or.po View 1 2 2 chunks +399 lines, -379 lines 0 comments Download
M po/pa.po View 1 2 2 chunks +402 lines, -381 lines 0 comments Download
M po/pl.po View 1 2 4 chunks +408 lines, -387 lines 0 comments Download
M po/pt_BR.po View 1 2 3 chunks +410 lines, -388 lines 0 comments Download
M po/ru.po View 1 2 4 chunks +403 lines, -362 lines 0 comments Download
M po/sr.po View 1 2 4 chunks +385 lines, -360 lines 0 comments Download
M po/sr@latin.po View 1 2 4 chunks +385 lines, -360 lines 0 comments Download
M po/ta.po View 1 2 2 chunks +397 lines, -383 lines 0 comments Download
M po/te.po View 1 2 1 chunk +401 lines, -388 lines 0 comments Download
M po/tg.po View 1 2 2 chunks +287 lines, -306 lines 0 comments Download
M po/uk.po View 1 2 3 chunks +406 lines, -385 lines 0 comments Download
M po/vi.po View 1 2 4 chunks +405 lines, -364 lines 0 comments Download
M po/zh_CN.po View 1 2 2 chunks +395 lines, -372 lines 0 comments Download
M po/zh_HK.po View 1 2 2 chunks +405 lines, -364 lines 0 comments Download
M po/zh_TW.po View 1 2 1 chunk +397 lines, -375 lines 0 comments Download
M setup/main.py View 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Daiki Ueno
I was contacted by the author of this change. After hearing his explanation, I'm getting ...
12 years, 6 months ago (2012-05-15 07:47:51 UTC) #1
Peng
On 2012/05/15 07:47:51, Daiki Ueno wrote: > I was contacted by the author of this ...
12 years, 6 months ago (2012-05-15 15:51:10 UTC) #2
Majora700
12 years, 6 months ago (2012-05-15 16:39:23 UTC) #3
On 2012/05/15 15:51:10, Peng wrote:
> LGTM. Could you please update all po files by make update-po in p folder sa
> well.

And how should I go about doing that? I mean, I can easily update all the po
files, but I don't know how to rewrite history in my repository to add the po
file updates to the commit that has my string fixes.

I wonder about this because I know you like what I think of as "perfect" single
commits.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b