Issue 6211072: gtk3: don't show "missing" icon for each submenu

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6211072: gtk3: don't show "missing" icon for each submenu (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by Daiki Ueno

Modified:
12 years, 6 months ago

Reviewers:
shawn.p.huang, Peng

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

gtk3: don't show "missing" icon for each submenu BUG=none TEST=manually

Patch Set 1 #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	ui/gtk3/property.vala	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Daiki Ueno

When I set org.gnome.desktop.interface.menus-have-icons to true, all submenus have "missing" icons: http://ueno.fedorapeople.org/ibus-gtk3/ibus-submenu-icons.png This patch doesn't ...

12 years, 6 months ago (2012-05-21 06:53:22 UTC) #1

Peng

12 years, 6 months ago (2012-05-21 11:04:52 UTC) #2

lgtm
On 2012/05/21 06:53:22, Daiki Ueno wrote:
> When I set org.gnome.desktop.interface.menus-have-icons to true, all submenus
> have "missing" icons:
> http://ueno.fedorapeople.org/ibus-gtk3/ibus-submenu-icons.png
> 
> This patch doesn't set icon widget if icon is intentionally blank.

Expand All Messages | Collapse All Messages