Issue 6211069: code review 6211069: net/http: fix regression and mute known test failure for now

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6211069: code review 6211069: net/http: fix regression and mute known test failure for now (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by bradfitz

Modified:
11 years, 11 months ago

Reviewers:

CC:
golang-dev, adg

Visibility:
Public.

Description

net/http: fix regression and mute known test failure for now Two tests added in 820ffde8c are expected to fail until the fix for Issue 3540 goes back in (pending Windows net fixes), so make those tests just Logf for now, with a TODO to re-enable. Add a new client test. Rearrange the transport code to be more readable, and fix the bug from 820ffde8c where the persistConn was being closed before the body was fully ready. Fixes issue 3644 Updates issue 1967 (not yet fixed, but should be after Issue 3540)

Patch Set 1 #

Patch Set 2 : diff -r 3c702dae5f50 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3c702dae5f50 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r ee1e5d30541c https://go.googlecode.com/hg/ #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+69 lines, -44 lines)			Patch
	M	src/pkg/net/http/transport.go	View	1	2 chunks	+24 lines, -24 lines	0 comments	Download
	M	src/pkg/net/http/transport_test.go	View	1 2 3	5 chunks	+45 lines, -20 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 11 months ago (2012-05-19 13:42:51 UTC) #1

adg

LGTM http://codereview.appspot.com/6211069/diff/4003/src/pkg/net/http/transport_test.go File src/pkg/net/http/transport_test.go (right): http://codereview.appspot.com/6211069/diff/4003/src/pkg/net/http/transport_test.go#newcode66 src/pkg/net/http/transport_test.go:66: // just change to false, so we have ...

11 years, 11 months ago (2012-05-20 23:27:51 UTC) #2

bradfitz

11 years, 11 months ago (2012-05-21 17:39:38 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=c3cbd6798cc7 ***

net/http: fix regression and mute known test failure for now

Two tests added in 820ffde8c are expected to fail until the fix
for Issue 3540 goes back in (pending Windows net fixes), so
make those tests just Logf for now, with a TODO to re-enable.

Add a new client test.

Rearrange the transport code to be more readable, and fix the
bug from 820ffde8c where the persistConn was being closed before
the body was fully ready.

Fixes issue 3644
Updates issue 1967 (not yet fixed, but should be after Issue 3540)

R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/6211069

Expand All Messages | Collapse All Messages