code review 6211053: cmd/go: invoke godoc with import path when possible

cmd/go: invoke godoc with import path when possible
Also add -n -x flags to doc, fmt, vet.
Also shorten unknown command error.

Fixes issue 3612.
Fixes issue 3613.

[rsc, 2012-05-15 15:24:58]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2012-05-15 15:33:00]

LGTM

http://codereview.appspot.com/6211053/diff/2001/src/cmd/go/main.go
File src/cmd/go/main.go (right):

http://codereview.appspot.com/6211053/diff/2001/src/cmd/go/main.go#newcode343
src/cmd/go/main.go:343: fmt.Printf("%s\n", strings.Join(cmdline, " "))
%q on command-line args with shell meta characters or spaces would be nice, at
least when runtime.GOOS != "windows".

[r, 2012-05-15 15:41:52]

LGTM
i wonder what the -n and -x flags do.

http://codereview.appspot.com/6211053/diff/2001/src/cmd/go/main.go
File src/cmd/go/main.go (right):

http://codereview.appspot.com/6211053/diff/2001/src/cmd/go/main.go#newcode343
src/cmd/go/main.go:343: fmt.Printf("%s\n", strings.Join(cmdline, " "))
mildly disagree. the quoting of %q is different enough to be wrong for the shell
in interesting cases. given that almost always the strings will not need quoting
(in fact, will they ever?) it seems wiser to let it be broken naturally in the
rare case they are rather than quote them always incorrectly. replacing one
erroneous representation with another isn't a fix.

[bradfitz, 2012-05-15 15:49:51]

On Tue, May 15, 2012 at 8:41 AM, <r@golang.org> wrote:

> LGTM
> i wonder what the -n and -x flags do.
>
>
>
>
>
http://codereview.appspot.com/**6211053/diff/2001/src/cmd/go/**main.go<http:/...
> File src/cmd/go/main.go (right):
>
> http://codereview.appspot.com/**6211053/diff/2001/src/cmd/go/**
>
main.go#newcode343<http://codereview.appspot.com/6211053/diff/2001/src/cmd/go/main.go#newcode343>
> src/cmd/go/main.go:343: fmt.Printf("%s\n", strings.Join(cmdline, " "))
> mildly disagree. the quoting of %q is different enough to be wrong for
> the shell in interesting cases. given that almost always the strings
> will not need quoting (in fact, will they ever?) it seems wiser to let
> it be broken naturally in the rare case they are rather than quote them
> always incorrectly. replacing one erroneous representation with another
> isn't a fix.
>

I meant more %q in the general sense of quoting.  But it can be done later
if needed.

[rsc, 2012-05-15 16:54:05]

the -n and -x output is never quoted right now.
it's meant to be suggestive, not exact.

[rsc, 2012-05-15 16:54:05]

*** Submitted as http://code.google.com/p/go/source/detail?r=5b1e024a5e89 ***

cmd/go: invoke godoc with import path when possible
Also add -n -x flags to doc, fmt, vet.
Also shorten unknown command error.

Fixes issue 3612.
Fixes issue 3613.

R=golang-dev, bradfitz, r
CC=golang-dev
http://codereview.appspot.com/6211053

[r, 2012-05-15 16:59:34]

for the record.

http://codereview.appspot.com/6211053/diff/3/src/cmd/go/main.go
File src/cmd/go/main.go (right):

http://codereview.appspot.com/6211053/diff/3/src/cmd/go/main.go#newcode147
src/cmd/go/main.go:147: fmt.Fprintf(os.Stderr, "go: unknown subcommand %#q\nRun
'go help' for usage.\n", args[0])
now that i think about it, this is an odd place to use %#q