code review 6209082: go.crypto/ssh: allow zero sized window adjustments

go.crypto/ssh: allow zero sized window adjustments

The RFC doesn't prohibit zero sized window adjustments and
there is evidence of well known clients using them in the
wild.

[dave_cheney.net, 2012-05-19 02:10:19]

Hello agl@golang.org, kardianos@gmail.com, gustav.paul@gmail.com (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go.crypto

[kardia, 2012-05-19 02:14:24]

LGTM

[dave_cheney.net, 2012-05-19 02:15:12]

Are you happy for me to submit this in place of your CL ?

On Sat, May 19, 2012 at 12:14 PM,  <kardianos@gmail.com> wrote:
> LGTM
>
> http://codereview.appspot.com/6209082/

[dave_cheney.net, 2012-05-19 02:18:33]

Hello agl@golang.org, kardianos@gmail.com, gustav.paul@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[dave_cheney.net, 2012-05-19 02:20:15]

I'll wait for agl for feedback from the server side.

[agl1, 2012-05-21 15:17:44]

LGTM

[dave_cheney.net, 2012-05-21 22:48:37]

Thank you. Will land this later today. 

On 22/05/2012, at 1:17, agl@golang.org wrote:

> LGTM
> 
> http://codereview.appspot.com/6209082/

[dave_cheney.net, 2012-05-22 02:04:57]

*** Submitted as
http://code.google.com/p/go/source/detail?r=f5b249bd8544&repo=crypto ***

go.crypto/ssh: allow zero sized window adjustments

The RFC doesn't prohibit zero sized window adjustments and
there is evidence of well known clients using them in the
wild.

R=agl, kardianos, gustav.paul
CC=golang-dev
http://codereview.appspot.com/6209082