Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1756)

Issue 6208073: skdiff: only write out diff images that are included in index.html (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by epoger
Modified:
12 years, 7 months ago
Reviewers:
TomH
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

skdiff: only write out diff images that are included in index.html Not only are those files unnecessary, in some different-image-size cases, their contents are nondeterministic! Committed: https://code.google.com/p/skia/source/detail?r=3975

Patch Set 1 #

Messages

Total messages: 4
epoger
12 years, 7 months ago (2012-05-16 15:56:04 UTC) #1
epoger
I'm gonna go ahead and commit this... if there are objections, I will roll it ...
12 years, 7 months ago (2012-05-16 17:39:58 UTC) #2
TomH
Ex post facto LGTM on the skdiff_main change. Why all deletions of the pngs?
12 years, 7 months ago (2012-05-16 17:44:00 UTC) #3
epoger
12 years, 7 months ago (2012-05-16 17:49:22 UTC) #4
On 2012/05/16 17:44:00, TomH wrote:
> Why all deletions of the pngs?

Because they aren't expected to be generated anymore.  (Due to the skdiff
change)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b