Issue 6208063: Make skdiff use enumeration of result types instead of separate booleans for each result type

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6208063: Make skdiff use enumeration of result types instead of separate booleans for each result type (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by epoger

Modified:
12 years, 6 months ago

Reviewers:
reed1, TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make skdiff use enumeration of result types instead of separate booleans for each result type. This is one step on the way to a more robust version of skdiff that we can use to address http://code.google.com/p/skia/issues/detail?id=473 ('PDF gradtext gm image results are nondeterministic') I have confirmed that skdiff results will not change, using tools/tests/run.sh. Committed: https://code.google.com/p/skia/source/detail?r=3972

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 4

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -34 lines)			Patch
	M	tools/skdiff_main.cpp	View	1 2 3 4	15 chunks	+68 lines, -34 lines	4 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

TomH

LGTM https://codereview.appspot.com/6208063/diff/8001/tools/skdiff_main.cpp File tools/skdiff_main.cpp (right): https://codereview.appspot.com/6208063/diff/8001/tools/skdiff_main.cpp#newcode828 tools/skdiff_main.cpp:828: case kBaseMissing: // fall through? https://codereview.appspot.com/6208063/diff/8001/tools/skdiff_main.cpp#newcode958 tools/skdiff_main.cpp:958: case ...

12 years, 6 months ago (2012-05-16 14:53:35 UTC) #2

TomH

On 2012/05/16 14:53:35, TomH wrote: > LGTM At last, victory is mine!

12 years, 6 months ago (2012-05-16 14:53:48 UTC) #3

epoger

Hey, when code review is rushed, EVERYBODY wins. Thanks... https://codereview.appspot.com/6208063/diff/8001/tools/skdiff_main.cpp File tools/skdiff_main.cpp (right): https://codereview.appspot.com/6208063/diff/8001/tools/skdiff_main.cpp#newcode828 tools/skdiff_main.cpp:828: ...

12 years, 6 months ago (2012-05-16 14:56:52 UTC) #4

TomH

12 years, 6 months ago (2012-05-16 14:58:22 UTC) #5

On 2012/05/16 14:56:52, epoger wrote:
> Hey, when code review is rushed, EVERYBODY wins.

Rushed? Hey, there were *6 whole seconds* per new line of code between request
for reviews and review submission!

Expand All Messages | Collapse All Messages