Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3805)

Issue 6207051: code review 6207051: go.crypto/ssh: introduce a circular buffer for chanReader (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by dfc
Modified:
7 years, 7 months ago
Reviewers:
CC:
agl1, gpaul, kardia, golang-dev
Visibility:
Public.

Description

go.crypto/ssh: introduce a circular buffer for chanReader

Patch Set 1 #

Patch Set 2 : diff -r d59e35c8940f https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r d59e35c8940f https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r d59e35c8940f https://code.google.com/p/go.crypto #

Patch Set 5 : diff -r d59e35c8940f https://code.google.com/p/go.crypto #

Patch Set 6 : diff -r d59e35c8940f https://code.google.com/p/go.crypto #

Total comments: 13

Patch Set 7 : diff -r d59e35c8940f https://code.google.com/p/go.crypto #

Patch Set 8 : diff -r d59e35c8940f https://code.google.com/p/go.crypto #

Patch Set 9 : diff -r d59e35c8940f https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+196 lines, -39 lines) Patch
A ssh/buffer.go View 1 2 3 4 5 6 7 1 chunk +96 lines, -0 lines 0 comments Download
A ssh/buffer_test.go View 1 2 3 4 5 1 chunk +87 lines, -0 lines 0 comments Download
M ssh/client.go View 1 2 3 4 4 chunks +13 lines, -39 lines 0 comments Download

Messages

Total messages: 8
dfc
Hello agl@golang.org, gustav.paul@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto
7 years, 7 months ago (2012-05-11 21:14:38 UTC) #1
dfc
Hello agl@golang.org, gustav.paul@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
7 years, 7 months ago (2012-05-11 21:28:15 UTC) #2
agl1
LGTM. I did think about merging the ring buffer and window tracking code. However I ...
7 years, 7 months ago (2012-05-14 15:21:30 UTC) #3
dfc
On 2012/05/14 15:21:30, agl1 wrote: > LGTM. > > I did think about merging the ...
7 years, 7 months ago (2012-05-15 01:12:03 UTC) #4
dfc
Thank you for your comments. I'm going to bang on this for a bit more ...
7 years, 7 months ago (2012-05-15 01:12:57 UTC) #5
dfc
Hello agl@golang.org, gustav.paul@gmail.com, kardianos@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.
7 years, 7 months ago (2012-05-15 08:03:48 UTC) #6
agl1
LGTM http://codereview.appspot.com/6207051/diff/4/ssh/buffer.go File ssh/buffer.go (right): http://codereview.appspot.com/6207051/diff/4/ssh/buffer.go#newcode42 ssh/buffer.go:42: // write makes buf available for Read to ...
7 years, 7 months ago (2012-05-15 15:30:06 UTC) #7
dfc
7 years, 7 months ago (2012-05-15 22:04:02 UTC) #8
*** Submitted as
http://code.google.com/p/go/source/detail?r=b24d6db9878e&repo=crypto ***

go.crypto/ssh: introduce a circular buffer for chanReader

R=agl, gustav.paul, kardianos
CC=golang-dev
http://codereview.appspot.com/6207051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b