LGTM. (Although, are we testing significant different functionality with this? Or is it just a ...
12 years, 7 months ago
(2012-05-18 18:08:33 UTC)
#2
LGTM.
(Although, are we testing significant different functionality with this? Or is
it just a convenient test to add to test our system & method for adding new
tests?)
On 2012/05/18 18:08:33, TomH wrote: > LGTM. > > (Although, are we testing significant different ...
12 years, 7 months ago
(2012-05-18 18:24:50 UTC)
#3
On 2012/05/18 18:08:33, TomH wrote:
> LGTM.
>
> (Although, are we testing significant different functionality with this? Or is
> it just a convenient test to add to test our system & method for adding new
> tests?)
My hidden agenda (hidden no more): I will soon be adding functionality to skdiff
whereby the return value will change depending on whether mismatches were found
or not. This change will allow us to actually test that behavior.
Issue 6206085: skdiff test-only change: add test of --nodiffs mode, make tests validate return value
(Closed)
Created 12 years, 7 months ago by epoger
Modified 12 years, 7 months ago
Reviewers: TomH
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0