Issue 6206085: skdiff test-only change: add test of --nodiffs mode, make tests validate return value

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6206085: skdiff test-only change: add test of --nodiffs mode, make tests validate return value (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by epoger

Modified:
12 years, 6 months ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

skdiff test-only change: add test of --nodiffs mode, make tests validate return value Committed: https://code.google.com/p/skia/source/detail?r=3999

Patch Set 1 #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -1 line)			Patch
M	tools/tests/run.sh	View	1 chunk	+6 lines, -1 line	0 comments	Download
A	tools/tests/skdiff/test1/output-expected/command_line	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	tools/tests/skdiff/test1/output-expected/return_value	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	tools/tests/skdiff/test2/output-expected/command_line	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	tools/tests/skdiff/test2/output-expected/return_value	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	tools/tests/skdiff/test2/output-expected/stdout	View	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

TomH

LGTM. (Although, are we testing significant different functionality with this? Or is it just a ...

12 years, 6 months ago (2012-05-18 18:08:33 UTC) #2

epoger

12 years, 6 months ago (2012-05-18 18:24:50 UTC) #3

On 2012/05/18 18:08:33, TomH wrote:
> LGTM.
> 
> (Although, are we testing significant different functionality with this? Or is
> it just a convenient test to add to test our system & method for adding new
> tests?)

My hidden agenda (hidden no more): I will soon be adding functionality to skdiff
whereby the return value will change depending on whether mismatches were found
or not.  This change will allow us to actually test that behavior.

Expand All Messages | Collapse All Messages