Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(29)

Issue 62056: Client side changes to Templates and Data Pipelining

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years, 9 months ago by levik
Modified:
11 years, 2 months ago
Reviewers:
opensocial.evan, shindig.remailer
Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Description

Changes to client-side Templates implementation - @field support for DataPipelining - removed need for jstemplate_debug.js file - added rudimentary typing to identifier resolution - @repeat values are requested as arrays - when arrays are requested and objects found, we now look for the .list property (this enables proper DP support) - fixed passing in defaults for compilation (only the last element is defaulted) - @onAttach is also supported as @onChange, @onchange, @x-onChange and @x-onchange JIRA Issue: https://issues.apache.org/jira/browse/SHINDIG-1061

Patch Set 1 #

Patch Set 2 : See updated description #

Patch Set 3 : deleted jstemplate_debug.js, added check to return default in getFromContext #

Patch Set 4 : Fixed timing of getting data sets for @autoUpdate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -69 lines) Patch
M features/src/main/javascript/features/opensocial-data/data.js View 1 2 chunks +25 lines, -3 lines 0 comments Download
M features/src/main/javascript/features/opensocial-templates/base.js View 2 chunks +7 lines, -8 lines 0 comments Download
M features/src/main/javascript/features/opensocial-templates/compiler.js View 2 7 chunks +21 lines, -6 lines 0 comments Download
M features/src/main/javascript/features/opensocial-templates/container.js View 2 chunks +12 lines, -3 lines 0 comments Download
M features/src/main/javascript/features/opensocial-templates/feature.xml View 1 1 chunk +0 lines, -1 line 0 comments Download
M features/src/main/javascript/features/opensocial-templates/jsTemplate/jstemplate.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
D features/src/main/javascript/features/opensocial-templates/jstemplate_debug.js View 1 chunk +0 lines, -43 lines 0 comments Download
M features/src/main/javascript/features/opensocial-templates/os.js View 1 chunk +4 lines, -0 lines 0 comments Download
M features/src/main/javascript/features/opensocial-templates/template.js View 1 chunk +1 line, -0 lines 0 comments Download
M features/src/test/javascript/features/opensocial-templates/compiler_test.js View 2 chunks +4 lines, -1 line 0 comments Download
M features/src/test/javascript/features/opensocial-templates/index.html View 1 chunk +1 line, -1 line 0 comments Download
M java/server/src/test/resources/endtoend/opensocial-templates/compiler_test.js View 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b