Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14)

Issue 6203089: Moved error-handling to a separate class - Diagnostics. We were earlier returning errors as tokens … (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 11 months ago by Alok Priyadarshi
Modified:
11 years, 11 months ago
Reviewers:
kbr1
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Moved error-handling to a separate class - Diagnostics. We were earlier returning errors as tokens which did not work very well when error occured while parsing a preprocessor directive. Now all returned tokens are valid. Errors are reported via an abstract Diagnostics interface. Updated unit-tests with the new scheme. Committed: https://code.google.com/p/angleproject/source/detail?r=1087

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+456 lines, -200 lines) Patch
M src/build_angle.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
A src/compiler/preprocessor/new/Diagnostics.h View 1 chunk +57 lines, -0 lines 0 comments Download
A src/compiler/preprocessor/new/Diagnostics.cpp View 1 chunk +34 lines, -0 lines 0 comments Download
M src/compiler/preprocessor/new/DirectiveParser.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/compiler/preprocessor/new/DirectiveParser.cpp View 5 chunks +22 lines, -6 lines 0 comments Download
M src/compiler/preprocessor/new/ExpressionParser.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/compiler/preprocessor/new/ExpressionParser.cpp View 6 chunks +26 lines, -14 lines 0 comments Download
M src/compiler/preprocessor/new/ExpressionParser.y View 5 chunks +23 lines, -11 lines 0 comments Download
M src/compiler/preprocessor/new/MacroExpander.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/compiler/preprocessor/new/MacroExpander.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/preprocessor/new/Preprocessor.h View 2 chunks +5 lines, -2 lines 0 comments Download
M src/compiler/preprocessor/new/Preprocessor.cpp View 2 chunks +6 lines, -4 lines 0 comments Download
A src/compiler/preprocessor/new/SourceLocation.h View 1 chunk +38 lines, -0 lines 0 comments Download
M src/compiler/preprocessor/new/Token.h View 4 chunks +5 lines, -27 lines 0 comments Download
M src/compiler/preprocessor/new/Tokenizer.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/compiler/preprocessor/new/Tokenizer.cpp View 6 chunks +23 lines, -10 lines 0 comments Download
M src/compiler/preprocessor/new/Tokenizer.l View 5 chunks +25 lines, -12 lines 0 comments Download
M tests/build_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A tests/preprocessor_tests/MockDiagnostics.h View 1 chunk +20 lines, -0 lines 0 comments Download
M tests/preprocessor_tests/char_test.cpp View 2 chunks +44 lines, -48 lines 0 comments Download
M tests/preprocessor_tests/comment_test.cpp View 4 chunks +20 lines, -10 lines 0 comments Download
M tests/preprocessor_tests/identifier_test.cpp View 1 chunk +7 lines, -3 lines 0 comments Download
M tests/preprocessor_tests/input_test.cpp View 1 chunk +11 lines, -5 lines 0 comments Download
M tests/preprocessor_tests/location_test.cpp View 9 chunks +22 lines, -18 lines 0 comments Download
M tests/preprocessor_tests/number_test.cpp View 4 chunks +20 lines, -11 lines 0 comments Download
M tests/preprocessor_tests/operator_test.cpp View 2 chunks +7 lines, -3 lines 0 comments Download
M tests/preprocessor_tests/space_test.cpp View 4 chunks +18 lines, -11 lines 0 comments Download

Messages

Total messages: 2
Alok Priyadarshi
11 years, 11 months ago (2012-05-17 20:00:49 UTC) #1
kbr1
11 years, 11 months ago (2012-05-17 20:33:59 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b