Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(20)

Issue 6201053: Move some constants from PyZyTypes to PyZyConfig (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 12 months ago by hsumita1
Modified:
11 years, 12 months ago
Reviewers:
Peng, Peng Huang, penghuang
Base URL:
git@github.com:pyzy/pyzy.git@master
Visibility:
Public.

Description

Move some constants from PyZyTypes to PyZyConfig BUG=None TEST=Manually

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Moves/Creates keyboard related constants. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -58 lines) Patch
M configure.ac View 1 chunk +1 line, -1 line 0 comments Download
M src/PyZyConfig.h View 1 2 2 chunks +53 lines, -8 lines 0 comments Download
M src/PyZyConfig.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/PyZyDatabase.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/PyZyDoublePinyinTable.h View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M src/PyZyPhoneticContext.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/PyZyPinyinParser.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/PyZySimpTradConverter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/PyZyTypes.h View 1 chunk +0 lines, -39 lines 0 comments Download

Messages

Total messages: 2
hsumita1
11 years, 12 months ago (2012-05-07 05:40:40 UTC) #1
Peng
11 years, 12 months ago (2012-05-07 14:14:51 UTC) #2
On 2012/05/07 05:40:40, hsumita1 wrote:

lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b