Issue 620041: Return verbatim String when converting overflow/truncated single-valued JSON data

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 620041: Return verbatim String when converting overflow/truncated single-valued JSON data (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years ago by johnfargo

Modified:
15 years, 11 months ago

Reviewers:
Paul Lindner, shindig.remailer, louiscryan

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

See comment in code.

Patch Set 1 #

Patch Set 2 : Actual implementation. #

Created: 16 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -2 lines)			Patch
		java/common/src/main/java/org/apache/shindig/common/util/JsonConversionUtil.java	View	1	1 chunk	+11 lines, -2 lines	0 comments	Download
		java/common/src/test/java/org/apache/shindig/common/util/JsonConversionUtilTest.java	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

fargo

16 years ago (2010-03-17 22:47:33 UTC) #4

That was actually my original impl -- but it broke a number of weird test
cases (I didn't dive into why), and in general I wanted to be as
conservative as possible with this change. Non-lossy conversions work fine
already; it's just the lossy ones that break, and AFAIK nobody's actually
relying on the lossy conversion anywhere.

On Wed, Mar 17, 2010 at 3:39 PM, <zhoresh@gmail.com> wrote:

>
> http://codereview.appspot.com/620041/diff/3001/4002
> File
>
>
java/common/src/main/java/org/apache/shindig/common/util/JsonConversionUtil.java
> (right):
>
> http://codereview.appspot.com/620041/diff/3001/4002#newcode201
>
>
java/common/src/main/java/org/apache/shindig/common/util/JsonConversionUtil.java:201:
> return value;
> Can you skip the check and just always return value for length == 1?
>
>
> http://codereview.appspot.com/620041/show
>

Expand All Messages | Collapse All Messages