Issue 6200061: Generalized ChineseCalendar and added Korean sub-type implementation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6200061: Generalized ChineseCalendar and added Korean sub-type implementation

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 7 months ago by zkim

Modified:
10 years ago

Reviewers:
mscherer_g, yoshito_umaoka

Base URL:
Revision: 31804

Visibility:
Public.

Description

Please make a branch out of this. It currently computes Korean calendar when the locale is ULocale.KOREA and computes Chinese calendar for all other locales. There are some issues to discuss regarding this which I'll send to the emails once this gets on the branch. Thanks!

Patch Set 1 #

Patch Set 2 : Made changes based on yoshito's suggestions #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+616 lines, -71 lines)			Patch
		main/classes/core/src/com/ibm/icu/util/ChineseCalendar.java	View	1	32 chunks	+178 lines, -71 lines	0 comments	Download
		main/tests/core/src/com/ibm/icu/dev/test/calendar/KoreanTest.java	View		1 chunk	+438 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Made changes based on yoshito's suggestions

Expand All Messages | Collapse All Messages