Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1051)

Issue 6200061: Generalized ChineseCalendar and added Korean sub-type implementation

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by zkim
Modified:
9 years, 11 months ago
Reviewers:
mscherer_g, yoshito_umaoka
Base URL:
Revision: 31804
Visibility:
Public.

Description

Please make a branch out of this. It currently computes Korean calendar when the locale is ULocale.KOREA and computes Chinese calendar for all other locales. There are some issues to discuss regarding this which I'll send to the emails once this gets on the branch. Thanks!

Patch Set 1 #

Patch Set 2 : Made changes based on yoshito's suggestions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+616 lines, -71 lines) Patch
main/classes/core/src/com/ibm/icu/util/ChineseCalendar.java View 1 32 chunks +178 lines, -71 lines 0 comments Download
main/tests/core/src/com/ibm/icu/dev/test/calendar/KoreanTest.java View 1 chunk +438 lines, -0 lines 0 comments Download

Messages

Total messages: 2
zkim
12 years, 6 months ago (2012-05-10 00:57:43 UTC) #1
zkim
12 years, 5 months ago (2012-06-15 00:23:17 UTC) #2
Made changes based on yoshito's suggestions
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b