Issue 6197077: code review 6197077: tls: fix decoding of certLen in certificateMsg.unmarshal

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6197077: code review 6197077: tls: fix decoding of certLen in certificateMsg.unmarshal (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by mge

Modified:
12 years, 10 months ago

Reviewers:

CC:
golang-dev, agl1

Visibility:
Public.

Description

tls: fix decoding of certLen in certificateMsg.unmarshal certLen was decoded incorrectly if length > 2^16-1.

Patch Set 1 #

Patch Set 2 : diff -r 2d8e9028098e https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2d8e9028098e https://go.googlecode.com/hg/ #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	src/pkg/crypto/tls/handshake_messages.go	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mge

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 10 months ago (2012-05-11 23:16:03 UTC) #1

agl1

Thank you for that. However, I can't see that you've agreed to the contributors agreement: ...

12 years, 10 months ago (2012-05-14 14:29:47 UTC) #2

agl1

12 years, 10 months ago (2012-05-14 16:26:54 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=bcfa9fc88361 ***

crypto/tls: fix decoding of certLen in certificateMsg.unmarshal

certLen was decoded incorrectly if length > 2^16-1.

R=golang-dev, agl
CC=golang-dev
http://codereview.appspot.com/6197077

Committer: Adam Langley <agl@golang.org>

Expand All Messages | Collapse All Messages