Issue 6197058: code review 6197058: C: Jeremy Ellington (Google CLA)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6197058: code review 6197058: C: Jeremy Ellington (Google CLA) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by Sameer Ajmani

Modified:
12 years, 10 months ago

Reviewers:

CC:
golang-dev, rsc, jme_google.com

Visibility:
Public.

Description

C: Jeremy Ellington (Google CLA)

Patch Set 1 #

Patch Set 2 : diff -r 3ab9c81fc9b5 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 3ab9c81fc9b5 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 3ab9c81fc9b5 https://go.googlecode.com/hg/ #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	CONTRIBUTORS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Sameer Ajmani

Hello golang-dev@googlegroups.com (cc: jme@google.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 10 months ago (2012-05-07 14:23:03 UTC) #1

Sameer Ajmani

*** Submitted as http://code.google.com/p/go/source/detail?r=448f98d1af28 *** C: Jeremy Ellington (Google CLA) R=golang-dev, rsc CC=golang-dev, jme http://codereview.appspot.com/6197058

12 years, 10 months ago (2012-05-07 14:48:38 UTC) #3

Sameer Ajmani

12 years, 10 months ago (2012-05-07 14:53:32 UTC) #4

I misread the username: this was supposed to be jmeurin@google.com (who
uses the username jme on the codereview site).

Sent the correction in 6192057

S

On Mon, May 7, 2012 at 10:48 AM, <sameer@golang.org> wrote:

> *** Submitted as
>
http://code.google.com/p/go/**source/detail?r=448f98d1af28<http://code.google...
>
>
> C: Jeremy Ellington (Google CLA)
>
> R=golang-dev, rsc
> CC=golang-dev, jme
>
http://codereview.appspot.com/**6197058<http://codereview.appspot.com/6197058>
>
>
>
http://codereview.appspot.com/**6197058/<http://codereview.appspot.com/6197058/>
>

Expand All Messages | Collapse All Messages