Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2188)

Issue 6195099: [google][4.7]Port function reordering via linker plugin from google/gcc-4_6 branch

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by Sriraman
Modified:
12 years, 6 months ago
Reviewers:
eraman, davidxl
CC:
gcc-patches_gcc.gnu.org
Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/gcc-4_7/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25343 lines, -34 lines) Patch
M Makefile.def View 4 chunks +7 lines, -0 lines 0 comments Download
M Makefile.in View 36 chunks +1009 lines, -5 lines 0 comments Download
M configure View 2 chunks +7 lines, -0 lines 0 comments Download
M configure.ac View 2 chunks +7 lines, -0 lines 0 comments Download
A function_reordering_plugin/Makefile.am View 1 chunk +38 lines, -0 lines 0 comments Download
A function_reordering_plugin/Makefile.in View 1 chunk +548 lines, -0 lines 0 comments Download
A function_reordering_plugin/aclocal.m4 View 1 chunk +9008 lines, -0 lines 0 comments Download
A function_reordering_plugin/callgraph.h View 1 chunk +288 lines, -0 lines 0 comments Download
A function_reordering_plugin/callgraph.c View 1 chunk +746 lines, -0 lines 0 comments Download
A function_reordering_plugin/config.h.in View 1 chunk +68 lines, -0 lines 0 comments Download
A function_reordering_plugin/configure View 1 chunk +13086 lines, -0 lines 0 comments Download
A function_reordering_plugin/configure.ac View 1 chunk +14 lines, -0 lines 0 comments Download
A function_reordering_plugin/function_reordering_plugin.c View 1 chunk +308 lines, -0 lines 0 comments Download
M gcc/cgraphbuild.c View 1 chunk +8 lines, -0 lines 0 comments Download
M gcc/common.opt View 2 chunks +10 lines, -4 lines 0 comments Download
M gcc/config.host View 1 chunk +1 line, -0 lines 0 comments Download
M gcc/config.in View 1 chunk +5 lines, -0 lines 0 comments Download
M gcc/configure View 3 chunks +8 lines, -2 lines 0 comments Download
M gcc/configure.ac View 1 chunk +4 lines, -0 lines 0 comments Download
M gcc/doc/invoke.texi View 3 chunks +5 lines, -10 lines 0 comments Download
M gcc/final.c View 3 chunks +9 lines, -9 lines 0 comments Download
M gcc/gcc.c View 6 chunks +62 lines, -0 lines 0 comments Download
M gcc/opts.c View 1 chunk +4 lines, -0 lines 0 comments Download
M gcc/params.def View 1 chunk +4 lines, -4 lines 0 comments Download
A gcc/testsuite/g++.dg/tree-prof/callgraph-profiles.C View 1 chunk +40 lines, -0 lines 0 comments Download
M gcc/testsuite/lib/target-supports.exp View 1 chunk +24 lines, -0 lines 0 comments Download
M gcc/testsuite/lib/target-supports-dg.exp View 1 chunk +19 lines, -0 lines 0 comments Download
M gcc/tree-optimize.c View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Sriraman
Hi, This patch ports function reordering support into google/gcc-4_7 branch from google/gcc-4_6 branch. There are ...
12 years, 6 months ago (2012-05-17 01:51:07 UTC) #1
Sriraman
Hi, This patch ports function reordering support into google/gcc-4_7 branch from google/gcc-4_6 branch. There are ...
12 years, 6 months ago (2012-05-17 01:52:56 UTC) #2
Sriraman
Patch too large to be attached, rejected by gcc-patches. Please see: http://codereview.appspot.com/download/issue6195099_1.diff Thanks, -Sri. On ...
12 years, 6 months ago (2012-05-17 01:56:07 UTC) #3
davidxl
ok for google-4_7 branch. This should also be pushed to trunk. Thanks, David On Wed, ...
12 years, 6 months ago (2012-05-17 04:23:55 UTC) #4
Sriraman
12 years, 6 months ago (2012-05-17 16:58:41 UTC) #5
Patch committed. I am preparing to send to trunk by splitting this
into multiple patches.

Thanks,
-Sri.

On Wed, May 16, 2012 at 9:23 PM, Xinliang David Li <davidxl@google.com> wrote:
> ok for google-4_7 branch. This should also be pushed to trunk.
>
> Thanks,
>
> David
>
> On Wed, May 16, 2012 at 6:56 PM, Sriraman Tallam <tmsriram@google.com> wrote:
>> Patch too large to be attached, rejected by gcc-patches. Please see:
>>
>> http://codereview.appspot.com/download/issue6195099_1.diff
>>
>> Thanks,
>> -Sri.
>>
>> On Wed, May 16, 2012 at 6:52 PM, Sriraman Tallam <tmsriram@google.com>
wrote:
>>> Hi,
>>>
>>>  This patch ports function reordering support into google/gcc-4_7 branch
>>>  from google/gcc-4_6 branch.  There are 3 parts which are combined:
>>>
>>>  * Adding option -freoder-functions=callgraph.
>>>  * Dumping callgraph profiles in separate sections.
>>>  * The linker plugin itself.
>>>
>>>  Port revisions from google/gcc-4_6
>>>  r177289, r177308, r179104, r179289, r179303, r179404, r182447
>>>
>>>  into google/gcc-4_7
>>>
>>>  adding function reordering support via linker plugin invoked with option
>>>  -freorder-functions=callgraph.
>>>
>>> Patch also can be reviewed here: http://codereview.appspot.com/6195099
>>>
>>> function_reordering_plugin:
>>>
>>>       * config.h.in: Generate.
>>>       * configure: Generate.
>>>       * Makefile.in: New file.
>>>       * configure.ac: New file.
>>>       * callgraph.h: New file.
>>>       * callgraph.c: New file.
>>>       * function_reordering_plugin.c: New file.
>>>       * Makefile.am: Generate.
>>>       * aclocal.m4: Generate.
>>>
>>> gcc:
>>>       * doc/invoke.texi: Document -freorder-functions=*
>>>       * cgraphbuild.c (remove_cgraph_callee_edges): Preserve
>>>       callgraph till pass_final.
>>>       * configure: Regenerate.
>>>       * final.c (dump_cgraph_profiles): New function.
>>>       (rest_of_handle_final): Call dumping of cgraph profiles in
>>>       .gnu.text.callgraph sections.
>>>       * gcc.c (LINK_COMMAND_SPEC): Process -freorder-functions=
>>>       (set_func_reorder_linker_plugin_spec): New function.
>>>       (main): Call function reorder plugin.
>>>       * testsuite/lib/target-supports-dg.exp
>>>       (dg-require-section-exclude): New proc.
>>>       (dg-require-linker-function-reordering-plugin): New proc.
>>>       * testsuite/lib/target-supports.exp
>>>       (check_section_exclude_available): New proc.
>>>       (check_linker_function_reordering_plugin_supported): New proc.
>>>       * testsuite/g++.dg/tree-prof/callgraph-profiles.C: New test.
>>>       * config.in: undef FRPLUGINSONAME
>>>       * opts.c
>>>       * configure.ac (FRPLUGINSONAME): Define
>>>       * common.opt (fcallgraph-profiles-sections): Remove.
>>>       (freorder-functions=): New option.
>>>       * tree-optimize.c (gate_all_optimizations): Mark last cleanup of
>>>       callgraph.
>>>       * config.host: Set function reordering plugin.
>>>       * params.def (PARAM_NOTE_CGRAPH_SECTION_EDGE_THRESHOLD): Remove.
>>>       (PARAM_GNU_CGRAPH_SECTION_EDGE_THRESHOLD): Add.
>>>
>>> toplevel:
>>>       * Makefile.in: Regenerate.
>>>       * Makefile.def: Build function reordering plugin.
>>>       * configure.ac: Build function reordering plugin.
>>>       * configure: Regenerate.
>>>
>>> Patch attached.
>>>
>>> Thanks,
>>> -Sri.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b