code review 6195074: debug/elf: Expose entry point from Header in File struct.

debug/elf: Expose entry point from Header in File struct.
Fixes issue 3470.

[mjh, 2012-05-13 18:15:00]

gentle ping...

[rsc, 2012-05-15 14:53:40]

On Sun, May 13, 2012 at 2:15 PM,  <Matthew.Horsnell@gmail.com> wrote:
> gentle ping...

For what it's worth, it looks like you never ran 'hg mail 6195074', so
before this 'gentle ping' message we had never seen it.

Please remove the Entry type.  uint64 is used for addresses elsewhere,
and the Entry is just another kind of address.
The Machine and Type types exist because they are enumerations, to
avoid confusing one for another and so that the printing can use
symbolic names.  Those are not concerns with Entry.

Thanks.
Russ

[mjh, 2012-05-20 18:27:59]

Hello rsc@golang.org, golang-dev@googlegroups.com (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[mjh, 2012-05-21 12:56:57]

Ignore for now, for some reason only the removal of the elf.go file changes has
been reflected, there are minor changes to the file.go that have not been
included in this changeset. Will resubmit shortly.

[mjh, 2012-05-21 13:17:50]

Hello rsc@golang.org, golang-dev@googlegroups.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[rsc, 2012-05-22 03:22:00]

LGTM

Thanks.

[rsc, 2012-05-22 03:30:32]

*** Submitted as http://code.google.com/p/go/source/detail?r=4cf98a732e92 ***

debug/elf: Expose entry point from Header in File struct.
Fixes issue 3470.

R=rsc, golang-dev
CC=golang-dev
http://codereview.appspot.com/6195074

Committer: Russ Cox <rsc@golang.org>