Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14)

Issue 6195072: Various fixes for ARM without EDSP and ARMv6+

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by glandium
Modified:
9 years, 3 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Various fixes for ARM without EDSP and ARMv6+ In gfx/skia/src/opts/SkBlitRow_opts_arm.cpp, smulbb is used event when it's not supported by the target architecture. (gfx/skia/include/core/SkMath.h has guards for smulbb use, but there aren't in SkBlitRow_opts_arm.cpp) In gfx/skia/src/opts/SkBitmapProcState_opts_arm.cpp, Some code is conditional on the ARM architecture being >= 6, but the macro it uses to do that isn't defined, so in practice, this code is not used on ARMv6 and ARMv7.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -7 lines) Patch
M include/core/SkMath.h View 1 chunk +1 line, -4 lines 0 comments Download
M include/core/SkPostConfig.h View 1 chunk +45 lines, -0 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_arm.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M src/opts/SkBlitRow_opts_arm.cpp View 2 chunks +9 lines, -0 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b