Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(455)

Issue 6194056: code review 6194056: go: fix the import path "./..." not matching ".". (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by nigeltao
Modified:
12 years, 10 months ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

go: fix the import path "./..." not matching ".". Tested manually. Fixes issue 3554. Before: $ cd $GOROOT/src/pkg $ go list io io $ go list io/... io io/ioutil $ cd $GOROOT/src/pkg/io $ go list . io $ go list ./... io/ioutil After: $ cd $GOROOT/src/pkg $ go list io io $ go list io/... io io/ioutil $ cd $GOROOT/src/pkg/io $ go list . io $ go list ./... io io/ioutil $ go list ././... io io/ioutil $ go list ././.././io/... io io/ioutil $ go list ../image image $ go list ../image/... image image/color image/draw image/gif image/jpeg image/png $ go list ../.../template html/template text/template $ cd $GOROOT/src/pkg $ go list ./io io $ go list ./io/... io io/ioutil $ go list ./.../pprof net/http/pprof runtime/pprof $ go list ./compress can't load package: package compress: no Go source files in /home/nigeltao/go/src/pkg/compress $ go list ./compress/... compress/bzip2 compress/flate compress/gzip compress/lzw compress/zlib $ cd $GOROOT/src/pkg/code.google.com $ go list ./p/leveldb-go/... code.google.com/p/leveldb-go/leveldb code.google.com/p/leveldb-go/leveldb/crc code.google.com/p/leveldb-go/leveldb/db code.google.com/p/leveldb-go/leveldb/memdb code.google.com/p/leveldb-go/leveldb/memfs code.google.com/p/leveldb-go/leveldb/record code.google.com/p/leveldb-go/leveldb/table code.google.com/p/leveldb-go/manualtest/filelock $ go list ./p/.../truetype code.google.com/p/freetype-go/example/truetype code.google.com/p/freetype-go/freetype/truetype $ go list ./p/.../example warning: "./p/.../example" matched no packages $ go list ./p/.../example/... code.google.com/p/freetype-go/example/freetype code.google.com/p/freetype-go/example/gamma code.google.com/p/freetype-go/example/raster code.google.com/p/freetype-go/example/round code.google.com/p/freetype-go/example/truetype code.google.com/p/x-go-binding/example/imgview code.google.com/p/x-go-binding/example/xgb

Patch Set 1 #

Patch Set 2 : diff -r 8db1b9223486 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 8db1b9223486 https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r fc36a482fea3 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M src/cmd/go/main.go View 1 2 3 1 chunk +15 lines, -3 lines 0 comments Download

Messages

Total messages: 3
nigeltao
Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 10 months ago (2012-05-08 05:21:54 UTC) #1
rsc
LGTM Thanks. http://codereview.appspot.com/6194056/diff/5001/src/cmd/go/main.go File src/cmd/go/main.go (right): http://codereview.appspot.com/6194056/diff/5001/src/cmd/go/main.go#newcode507 src/cmd/go/main.go:507: // filepath.Walk starts and dir and recurses. ...
12 years, 10 months ago (2012-05-08 15:45:03 UTC) #2
nigeltao
12 years, 10 months ago (2012-05-09 00:43:35 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=cdd1fa20bb08 ***

go: fix the import path "./..." not matching ".".

Tested manually.

Fixes issue 3554.

Before:
$ cd $GOROOT/src/pkg
$ go list io
io
$ go list io/...
io
io/ioutil
$ cd $GOROOT/src/pkg/io
$ go list .
io
$ go list ./...
io/ioutil

After:
$ cd $GOROOT/src/pkg
$ go list io
io
$ go list io/...
io
io/ioutil
$ cd $GOROOT/src/pkg/io
$ go list .
io
$ go list ./...
io
io/ioutil
$ go list ././...
io
io/ioutil
$ go list ././.././io/...
io
io/ioutil
$ go list ../image
image
$ go list ../image/...
image
image/color
image/draw
image/gif
image/jpeg
image/png
$ go list ../.../template
html/template
text/template
$ cd $GOROOT/src/pkg
$ go list ./io
io
$ go list ./io/...
io
io/ioutil
$ go list ./.../pprof
net/http/pprof
runtime/pprof
$ go list ./compress
can't load package: package compress: no Go source files in
/home/nigeltao/go/src/pkg/compress
$ go list ./compress/...
compress/bzip2
compress/flate
compress/gzip
compress/lzw
compress/zlib
$ cd $GOROOT/src/pkg/code.google.com
$ go list ./p/leveldb-go/...
code.google.com/p/leveldb-go/leveldb
code.google.com/p/leveldb-go/leveldb/crc
code.google.com/p/leveldb-go/leveldb/db
code.google.com/p/leveldb-go/leveldb/memdb
code.google.com/p/leveldb-go/leveldb/memfs
code.google.com/p/leveldb-go/leveldb/record
code.google.com/p/leveldb-go/leveldb/table
code.google.com/p/leveldb-go/manualtest/filelock
$ go list ./p/.../truetype
code.google.com/p/freetype-go/example/truetype
code.google.com/p/freetype-go/freetype/truetype
$ go list ./p/.../example
warning: "./p/.../example" matched no packages
$ go list ./p/.../example/...
code.google.com/p/freetype-go/example/freetype
code.google.com/p/freetype-go/example/gamma
code.google.com/p/freetype-go/example/raster
code.google.com/p/freetype-go/example/round
code.google.com/p/freetype-go/example/truetype
code.google.com/p/x-go-binding/example/imgview
code.google.com/p/x-go-binding/example/xgb

R=rsc
CC=golang-dev
http://codereview.appspot.com/6194056
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b